- Issue created by @Dan.Ashdown
- Issue was unassigned.
- Status changed to Needs review
8 months ago 9:16am 20 October 2023 - Status changed to Needs work
8 months ago 9:41am 20 October 2023 - π¦πΉAustria fago Vienna
thank you! That looks generally good, but I think we need to little more cleaning up before merge:
* getBlocks() code-comments need to be updated to reflect the new argument
* I think we should make the new argument $cacheableDependency optional, keep it NULL when omitted and only add cache-dependencies when passed. That way, we can keep up proper BC, in case someone would already use the method (what I doubt though) - @danashdown opened merge request.
- Status changed to Needs review
8 months ago 9:52am 20 October 2023 - π¬π§United Kingdom Dan.Ashdown
Thanks for the feedback @fago! Updated to document the parameter and support BC.
I've also moved it to an MR.
- Status changed to Needs work
8 months ago 10:17am 20 October 2023 - π¦πΉAustria fago Vienna
thanks! I've found one issue with it though, please check!
- Status changed to Needs review
8 months ago 10:20am 20 October 2023 -
fago β
committed b189e106 on 1.x authored by
Dan.Ashdown β
Issue #3395503 by Dan.Ashdown, fago: Blocks Layout integration does not...
-
fago β
committed b189e106 on 1.x authored by
Dan.Ashdown β
- Status changed to Fixed
8 months ago 10:25am 20 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.