Created on 16 January 2023, over 1 year ago
Updated 9 February 2023, over 1 year ago

Adding Views support, see also:
https://github.com/drunomics/nuxtjs-drupal-ce/issues/98

This works with this change to drupal/lupus_ce_renderer https://www.drupal.org/project/lupus_ce_renderer/issues/3333827 πŸ“Œ Support Views Closed: won't fix

Patch to follow.

πŸ“Œ Task
Status

Closed: won't fix

Version

2.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Needs review over 1 year ago
  • Status changed to Needs work over 1 year ago
  • πŸ‡ΊπŸ‡¦Ukraine mostepaniukvm

    I tested the patch locally. Thanks for your contribution it's an indeed nice feature. It works well in general but unfortunately, it doesn't allow you to really switch to JSON content format. I investigated around and see that it's a little tricky and maybe even a challengeable as we first render view and later build custom_element from resulted HTML.
    Maybe we need to research if there are any other possible solutions that allow keeping control of content format in one place in code and avoid major changes in architecture.

    Additionally, I noticed that not only view rows were rendered into "rows" slot but also extra views wrapper tags. And as result we have outer rows slot and inner views-rows custom element. Maybe we can play with it to make the rendered content structure a little cleaner.
    Example:

    <view>
      <template #rows>
        <div class="views-element-container">
          <div class="view-id-test view-display-id-page_1">
            <div class="view-content">
              <views-rows>
                <template #row>
                  <drupal-markup>
                    <article role="article" class="node--view-mode-teaser">
                      ...
                    </article>
                  </drupal-markup>
                  <drupal-markup>
                    ...
                  </drupal-markup>
                  ...
                </template>
              </views-rows>
            </div>
          </div>
        </div>
      </template>
    </view>
    
  • Status changed to Closed: won't fix over 1 year ago
  • πŸ‡¬πŸ‡§United Kingdom Dan.Ashdown

    Replaced by https://www.drupal.org/project/lupus_decoupled/issues/3340520#comment-14... πŸ“Œ Views support Fixed

Production build 0.69.0 2024