- Status changed to Needs review
about 2 years ago 1:17pm 16 January 2023 - Status changed to Needs work
about 2 years ago 9:53am 23 January 2023 - πΊπ¦Ukraine mostepaniukvm
I tested the patch locally. Thanks for your contribution it's an indeed nice feature. It works well in general but unfortunately, it doesn't allow you to really switch to JSON content format. I investigated around and see that it's a little tricky and maybe even a challengeable as we first render view and later build custom_element from resulted HTML.
Maybe we need to research if there are any other possible solutions that allow keeping control of content format in one place in code and avoid major changes in architecture.Additionally, I noticed that not only view rows were rendered into "rows" slot but also extra views wrapper tags. And as result we have outer
rows
slot and innerviews-rows
custom element. Maybe we can play with it to make the rendered content structure a little cleaner.
Example:<view> <template #rows> <div class="views-element-container"> <div class="view-id-test view-display-id-page_1"> <div class="view-content"> <views-rows> <template #row> <drupal-markup> <article role="article" class="node--view-mode-teaser"> ... </article> </drupal-markup> <drupal-markup> ... </drupal-markup> ... </template> </views-rows> </div> </div> </div> </template> </view>
- Status changed to Closed: won't fix
almost 2 years ago 10:02am 9 February 2023 - π¬π§United Kingdom Dan.Ashdown
Replaced by https://www.drupal.org/project/lupus_decoupled/issues/3340520#comment-14... π Views support Fixed