Finally figured out where the issue was and created a patch. Could use a review.
phernand42 → created an issue.
Sorry for all the noise. Hopefully, this re-roll will past tests this time.
I am re-rolling again since I forgot to include test updates in the last patch (#5).
Re-rolling patch from #3 so it's compatible with the latest version of search API (1.33)
I'm getting this console error too. I'm on Drupal 10.1.8 and webform version 6.2.0. The error occurs on any settings page with an open text field. For instance, I am trying to add a confirmation message and I see that console error. Also the text keeps disappearing from text field after save. Not sure if that is related to this error though.
phernand42 → created an issue.
Tested patch in #2 on 3.0.0 alpha2 version and it applied cleanly
Yeah it didn't make it in unfortunately. Seems like the issue was automatically closed due to no activity. For anyone else who wants to apply this change to the latest version (3.0.0-alpha2) you can simply add the following link to your composer.json file (same as a patch link) that links directly to MR with changes. Of course review and test.
https://git.drupalcode.org/project/openid_connect/-/merge_requests/82.diff
Closed MR - https://git.drupalcode.org/project/openid_connect/-/merge_requests/82
Not sure these changes made it into the latest downloadable version (3.0.0-alpha2). I downloaded via composer and also checked zip download on module download page ( https://www.drupal.org/project/openid_connect/releases/3.0.0-alpha2 → ) and it still shows old code.
Since it was a minor change I went ahead and just created an MR for this change.
Anyway we can accept this and get module updated for D10?
Patch re-rolled to fix error mentioned in #27
After updating to Drupal 10.1.5 I started getting the following error in node edit screen even after applying patch in #23.
Deprecated function: Creation of dynamic property Drupal\ckeditor_templates\Plugin\CKEditorPlugin\CkeditorTemplates::$themeExtensionList is deprecated in Drupal\ckeditor_templates\Plugin\CKEditorPlugin\CkeditorTemplates->__construct() (line 58 of modules/contrib/ckeditor_templates/src/Plugin/CKEditorPlugin/CkeditorTemplates.php).
I found that declaring the $themeExtensionList property at the class level, before it's used in the constructor made the error go away.
/**
* Drupal Theme Extension List.
*
* @var \Drupal\Core\Extension\ThemeExtensionList
*/
private $themeExtensionList;
I'll revise patch in #23 to include this just in case anyone else encounters this error.
Sweet! Thanks @recrit
The patch is for 9.5 since I'm still on 9.5 (in the process of updating to 10 now though) but will try and cook one up for 10.1 later today.
Not sure we can get away from not including the style updates but could something like this work instead? This would resolve conflict with .claro-details__summary and remove dupe asterisks. I can try and update the patch and test it out.
.form-item__label.form-required::after,
.fieldset__label.form-required::after,
:not(.claro-details__summary).form-required::after {
display: inline-block;
margin-right: 0.15em;
margin-left: 0.15em;
content: "*";
color: #dc2323;
font-size: 0.875rem;
}
Giving it another go
Sorry for all the noise. Will do more testing and try and post an updated patch with passing tests
Trying again
Trying to remediate errors from failed tests from the last patch
Hello,
Love this idea and hope we can get this to work properly. I went ahead and updated the existing patch and included changes to the schema and settings files (chosen.schema.yml, chosen.settings.yml) per comment #4. Seems to be working ok on my end but could use some more testing. Also for setting up the default to be chosen.claro could we maybe do an update hook that sets the default configuration for existing installations?
Tested patch in #45 and it applied cleanly and worked fine on the current version of the module (8.x-1.4). However, after I removed the patch, the "saving draft" notification keeps appearing right away whenever I edit a page. The current time interval I have setup to trigger autosave is 20000 milliseconds. So I shouldn't see the "saving draft" notification right when I edit a page. I doubled checked module code to make sure none of the patch code was still present and it wasn't. Not entirely sure if this is related to patch or not but I thought I should share.