Embed icon not getting updated in WYSIWYG toolbar

Created on 24 April 2024, about 2 months ago

Updated 9 June 2024, 14 days ago

Problem/Motivation

I am trying to use a different icon for paragraph entity embed in my WYSIWYG toolbar. When I go to update icon for paragraph entity embed in admin/config/content/embed I can upload my new SVG icon and see it in the preview area but when I go to my node edit screen and try and view the updated icon in WYSIWYG I see the default icon instead. After reviewing the module code I did notice the paragraph icon seems to be hard coded instead of it being dynamic and pulling from the embed form page. I'm also using CKeditor 5 for my WYSIWYG and on Drupal 10.1.

https://git.drupalcode.org/project/paragraphs_entity_embed/-/blob/3.0.x/...

https://git.drupalcode.org/project/paragraphs_entity_embed/-/blame/3.0.x...

Steps to reproduce

1. Navigate to admin/config/content/embed
2. Edit embed button for paragraph entity embed
3. Upload new SVG icon and save
4. Navigate to node edit screen or wherever you have paragraph entity embed enabled and see if icon is updated in WYSIWYG toolbar.

Proposed resolution

Embed icon should get updated if new one is uploaded.

🐛 Bug report

Status

Needs work

Version

3.0

Component

User interface

Created by

🇺🇸United States phernand42

Live updates comments and jobs are added and updated live.

Merge Requests

!18Embed icon not getting updated in WYSIWYG toolbar
Open
🇺🇸United States smustgrave
updated 14 days ago

Comments & Activities

Issue created by @phernand42
Comment about 2 months ago →
🇺🇸United States phernand42
Comment about 2 months ago →
🇺🇸United States phernand42
Finally figured out where the issue was and created a patch. Could use a review.
Status changed to Needs review about 2 months ago6:00pm 1 May 2024
Comment about 2 months ago →
🇺🇸United States phernand42
First commit to issue fork.
Merge request !18Issue #3443296 by phernand42: Embed icon not getting updated in WYSIWYG toolbar → (Open) created by smustgrave
Status changed to Needs work 14 days ago11:47pm 9 June 2024
Comment 14 days ago →
🇺🇸United States smustgrave
Tested out and on a node edit page it does seem to update but on the text format edit page it's still using the default image

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024