Trying to access array offset on value of type null in Drupal\openid_connect\Form\OpenIDConnectSettingsForm->buildForm()

Please review.

Is it possible that this error is caused by a missing default value for those fields? If I simply save the form, the problem persists, but if I edit even just one of those fields, then the error disappears. I can see that the openid_connect.settings now has one extra attribute:

role_mappings:
  ...
 <one line for each role>
 ...

oops.. sorry, cross-posting, I did not see the "Please review message"

I think it works!
I still get:
Warning: foreach() argument must be of type array|object, null given in Drupal\openid_connect\OpenIDConnect->saveUserinfo() (line 711 of modules/contrib/openid_connect/src/OpenIDConnect.php).
after login, probably because I haven't specified a single role mapping, so the foreach() still gets a 'null'.

Loosely related to this issue: possibility to turn off role mapping. It's related in the sense that if there's such a setting, it would impact all places like this where it's assumed the role_mappings is populated.

Please review.

All good to me!

Hello,

I cannot apply this patch to either 3.0.0-alpha2 or head of 3.x branch ?

jcnventura → closed merge request !78

Thanks for this

jcnventura → closed merge request !82

Automatically closed - issue fixed for 2 weeks with no activity.

Anyway we can have this fix available on a new version ?

Not sure these changes made it into the latest downloadable version (3.0.0-alpha2). I downloaded via composer and also checked zip download on module download page ( https://www.drupal.org/project/openid_connect/releases/3.0.0-alpha2 → ) and it still shows old code.

Yeah it didn't make it in unfortunately. Seems like the issue was automatically closed due to no activity. For anyone else who wants to apply this change to the latest version (3.0.0-alpha2) you can simply add the following link to your composer.json file (same as a patch link) that links directly to MR with changes. Of course review and test.

https://git.drupalcode.org/project/openid_connect/-/merge_requests/82.diff

Closed MR - https://git.drupalcode.org/project/openid_connect/-/merge_requests/82

#23 proposition worked for me
Thanks

Problem still present in 3.0.0-alpha2, solution described in #23 seems to fix it.

mably → changed the visibility of the branch 3355330-3.x-reroll to active.