-
mogtofu33 β
committed 0fc5c40a on 1.0.x
Issue #3538026 by pdureau, mogtofu33, just_like_good_vibes: Implement...
-
mogtofu33 β
committed 0fc5c40a on 1.0.x
- π«π·France pdureau Paris
This is also the opportunity to add
getSummary()
on island forms -
mogtofu33 β
committed 1de8f3c7 on 1.0.x
Issue #3538026 by pdureau, mogtofu33, just_like_good_vibes: Implement...
-
mogtofu33 β
committed 1de8f3c7 on 1.0.x
- @mogtofu33 opened merge request.
- First commit to issue fork.
- π©πͺGermany Christian.wiedemann
christian.wiedemann β made their first commit to this issueβs fork.
-
mogtofu33 β
committed b400c891 on 1.0.x authored by
pdureau β
Issue #3535989 by pdureau: Add an ActiveUsers island
-
mogtofu33 β
committed b400c891 on 1.0.x authored by
pdureau β
-
mogtofu33 β
committed c6aacb7f on 1.0.x authored by
yannickoo β
Issue #3538195 by yannickoo: Z-index is still too low to cover...
-
mogtofu33 β
committed c6aacb7f on 1.0.x authored by
yannickoo β
- π©πͺGermany yannickoo Berlin
In my case it was not applied due to Gin theme. I have added 2 more selectors which are covering the Gin vertical toolbar and the "fake navigation" bar that the theme provides as well.
- π«π·France pdureau Paris
Everything done.
Follow-up: π WithDisplayBuilderInterface follow-ups Active
- @yannickoo opened merge request.
- Issue created by @yannickoo
- π«π·France pdureau Paris
I take it back, i need to add little rule in
::initInstanceIfMissing()
- π«π·France pdureau Paris
Tested with Mikael, works OK.
However, we need to apply this drafty patch to make it works:
diff --git a/modules/display_builder_entity_view/src/Entity/DisplayBuilderEntityViewDisplay.php b/modules/display_builder_entity_view/src/Entity/DisplayBuilderEntityViewDisplay.php index bb35966..4d731fb 100644 --- a/modules/display_builder_entity_view/src/Entity/DisplayBuilderEntityViewDisplay.php +++ b/modules/display_builder_entity_view/src/Entity/DisplayBuilderEntityViewDisplay.php @@ -238,7 +238,7 @@ class DisplayBuilderEntityViewDisplay extends LayoutBuilderEntityViewDisplay imp $this->stateManager->create($instance_id, (string) $this->getDisplayBuilder()->id(), [], $contexts); // Careful. StateManager::create() is not saving properly the contexts. // Let's do it again. - $this->stateManager->setContexts($instance_id, $contexts); + //$this->stateManager->setContexts($instance_id, $contexts); } /** diff --git a/src/IslandPluginBase.php b/src/IslandPluginBase.php index dd69177..f76e068 100644 --- a/src/IslandPluginBase.php +++ b/src/IslandPluginBase.php @@ -47,7 +47,7 @@ abstract class IslandPluginBase extends PluginBase implements IslandInterface { /** * The contexts for islands. */ - protected array $contexts = []; + //protected array $contexts = []; /** * {@inheritdoc} @@ -64,8 +64,8 @@ abstract class IslandPluginBase extends PluginBase implements IslandInterface { ) { parent::__construct($configuration, $plugin_id, $plugin_definition); $this->data = $configuration; - $this->contexts = $configuration['contexts'] ?? []; - unset($configuration['contexts']); + // $this->contexts = $configuration['contexts'] ?? []; + // unset($configuration['contexts']); $this->setConfiguration($configuration); }
It is related to π Add the island configuration forms Active
- π«π·France just_like_good_vibes PARIS
pdureau β credited just_like_good_vibes β .
- @pdureau opened merge request.
- π«π·France pdureau Paris
Remain work:
- Regression, display not rendered. Looks like a context issue.
- Remove
DisplayBuilder::DISPLAY_BUILDER_CONFIG
again - Update devel controller again
- Issue created by @pdureau
- @mogtofu33 opened merge request.