- ๐ท๐ธSerbia finnsky
finnsky โ changed the visibility of the branch 11.x-3457061-modal-dialog to hidden.
- ๐ท๐ธSerbia finnsky
Yes. Core has Backward compatibility for jQuery listeners but not for jQuery triggers.
It seems pretty weird to expect that events will work same if they triggered differently than in core. - ๐ฆ๐บAustralia ELC
Confused. The file is in Drupal Core, not a contrib module?
- ๐ท๐ธSerbia finnsky
Imo this should be done on level of module. It trigger jQuery events. But in fact they should be vanilla events.
Opened own issue
https://www.drupal.org/project/bootstrap4_modal/issues/3457776 โจ Update events triggers Active - ๐ท๐ธSerbia finnsky
With Bootstrap 4 modal no issues when anonymous user
https://gyazo.com/ce11b077b994b2fd529d4b0575f0119dSome issues when admin. Digging..
- ๐ท๐ธSerbia finnsky
Probably was meant this module?
- ๐ท๐ธSerbia finnsky
Bootstrap 3 with 10.3 also fine https://gyazo.com/1dd24fce160909e55df685d0171578b3
- ๐ท๐ธSerbia finnsky
Bootstrap 5 with 10.3 works fine https://gyazo.com/e8167563a2cc0868bcdc842037ba9be1
- ๐ท๐ธSerbia finnsky
Which bootstrap theme i have to test with?
Not even one of them cannot be applied on 11.x - First commit to issue fork.
- ๐บ๐ธUnited States KarlShea Minneapolis, ๐บ๐ธ
The MR can't be fixed until it's targeting the right branch, that's why it shows hundreds of commits.
- @elc opened merge request.
- ๐ฆ๐บAustralia ELC
Attempted to fix the MR to work against 11.x-dev but it is too far broken. Appears to have been forked in the wrong branch and then merged across which has put it out of sync with everything and I can't find which of the hundreds of commits to purge to get it back to normal.
- ๐บ๐ธUnited States KarlShea Minneapolis, ๐บ๐ธ
The MR needs to target 11.x, not 11.0.x. I rebased it on 11.x but I can't edit the MR.
- First commit to issue fork.
- ๐บ๐ธUnited States smustgrave
Thanks for turning to an MR but as mentioned in #10 this needs to go against 11.x as the current development branch
Also tagged for steps to reproduce and potential test coverage.
- @jhinarivgmailcom opened merge request.
- ๐บ๐ธUnited States smustgrave
11.x is the current development branch so fixes need to land their first, just FYI
- @jhinarivgmailcom opened merge request.
- ๐จ๐ดColombia jhina.riv@gmail.com
jhina.riv@gmail.com โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States smustgrave
Can this be reproduced in 11.x also? the current "main" branch
MR should be opened against 11.x
What are the steps for reproducing?
Will also need test coverage
- Issue created by @Sunil Chaurasiya