Update.php doesn't display errors correctly

Created on 5 October 2009, almost 15 years ago
Updated 13 February 2023, over 1 year ago

When updating from admin_menu 6.x-3.0-alpha1 to 6.x-3.0-alpha3 in Drupal 6.14 I received the following PHP warning:

array_pop(): The argument should be an array in [path]/update.php on line 314.

The line in question is:


list($module, $version) = array_pop(reset($_SESSION['updates_remaining']));

In D7 HEAD the line has been moved to 127 but is otherwise identical.

When I ran update.php again, the update finished normally. In both cases it was the only module that had changed (I updated nodewords just before that, but had already run update.php for that).

The main problem might be with the admin_menu module, but the fact that update.php doesn't handle it gracefully and doesn't give useful feedback is a bug in update.php.

Just reporting for now, hopefully patch to come later.

πŸ› Bug report
Status

Closed: cannot reproduce

Version

9.5

Component
Database updateΒ  β†’

Last updated 9 days ago

No maintainer
Created by

πŸ‡ΊπŸ‡ΈUnited States kwinters

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs backport to D7

    After being applied to the 8.x branch, it should be considered for backport to the 7.x branch. Note: This tag should generally remain even after the backport has been written, approved, and committed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    This has been triaged twice in 3 years by the Bug Smash initiative by different people. One pointed out that there was a comment saying the problem was not reproducible. In both comments more information is asked for so that the problem can be reproduced. Since that information hasn't been supplied, the latest request was 4 months ago, it is time to close the long standing issue.

    Since #3 stated the original problem was not reproducible I am closing as cannot reproduce. you are experiencing this problem on a supported version of Drupal reopen the issue, by setting the status to 'Active', and provide complete steps to reproduce the issue β†’ (starting from "Install Drupal core").

Production build 0.71.5 2024