hook_field_type_category_info_alter should not be in group field_purge

Another fix would be to move the hook above the opening of the group:

/**
 * @addtogroup field_purge
 * @{
 */

In fact, it would be a good idea to reorganize all the hooks in field.api.php, but that would not be a Novice task. In the Proposed resolution, I recommend moving the hook after the close of the group for two reasons:

1. It is the minimal change to fix the problem.
2. If another issue adds a new hook to the end of the file, then that new hook will be outside the group.

Good catch thanks! I agree this is novice with the scope in the issue summary.

@luismagr please create the MR, i left instructive in this comment: https://www.drupal.org/project/drupal/issues/2943436#comment-16253399 📌 Review all tests where system module is the only dependency Active

Tests passed now. I'd say this is ready for review

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Right, I'm not able to find how to fix what needs-review-queue-bot says. The txt file indicate there's a phpstan error on field.api.php however, I'm not able to run it locally. Running phpstan locally scan the src directory, the test and If I run it with -l 5 I can see field.module and field.purge.inc but not the field.api.php one.

Any advice here would be great.

Thanks

So when there is something like that is usually means a rule changed upstream.

You need to rebase or update the fork to fix that, there are two ways to do this, one in the UI and one locally.

In the UI:
1. click on branch (not the MR) the link is called: 3544005-hookfieldtypecategoryinfoalter-should-not
2. Click update fork on the right

Locally:
1. checkout 11.x from head
2. git fetch
3. git rebase
4. Checkout this branch again
5. git rebase 11.x

Note that you will need to properly resolve conflicts if you rebase and is a bit beyond the scope of this issue so if you're not familiar with rebasing I would try the UI version and do some reading on rebasing.

I've updated the brach using the UI. We'll see what the bot says now.

Thanks again @nicxvan :)

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

I did it using the UI. I normally merge instead of rebasing but if that's the workflow I'm ok to do it manually. In this case I didn't want toncomplicate things.

I updated the branch with upstream and marked the issue as "needs review" but still got the same result. I can see it failed but there are no logs of what's exactly wrong.

I'll try tomorrow again to see if I can replicate it locally

Pipeline is failing. Needs to be checked

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.