Review all tests where system module is the only dependency

This should be a pretty good novice task.

Hi,

I'm going to go through the tests and add all the failed ones on the remaining task section when I finish so I only have to update the section once if that's ok.

Thanks

Hi all,

I've pushed to the Issue fork individual commits per test and updated the list of remaining tests to remove the dependency. From here, I'm not sure if we want to fix them under this issue or if we want to create individual issues for each one.

Thanks

@luismagr, Can you make an MR so the tests run?

Whoops forgot this was novice and created the MR.

@luismagr great work so far! I created the MR in the future you can do that after pushing by clicking compare next to the branch on the issue then clicking create Merge request on the next page.

This is green, I think a good final step world be to remove it from FileTestBase and see if any tests fail.

Thanks @quietone and @nicxvan

Understanding the workflow was the idea behind working on this issue. Will create it next time for sure. Thanks for creating it this time.

What about the abstract class FileTestBase? Do we need to commit it as part of the changes? Happy to commit it as part of the work.

Thanks

It doesn't like the removal from FileTestBase. Shall we revert the commit or do we need to look at that change? Before the commit pipeline was green.

An example of running the test locally. I got this

1) Drupal\KernelTests\Core\File\FileMoveTest::testNormal
Drupal\Core\Config\Schema\SchemaIncompleteException: No schema for system.file

/var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:91
/var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:246
/var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:206
/var/www/html/vendor/symfony/event-dispatcher/EventDispatcher.php:56
/var/www/html/core/lib/Drupal/Core/Config/Config.php:232
/var/www/html/core/tests/Drupal/KernelTests/Core/File/FileTestBase.php:43

I guess the dependency needs to be injected at some other point

Yes let's revert that thank you.

Reverted the one failing and added it to the remaining tasks section. Now is green again

Btw @nicxvan, is this issue now in "needs review" or is it panned to fix the remaining tests in this one?