- Issue created by @Anybody
- 🇨🇦Canada danrod Ottawa
I'd like to work on this, I'll take it, if you don't mind.
- 🇩🇪Germany Anybody Porta Westfalica
Also see 📌 Fix the issues reported by phpcs RTBC - maybe that's a good starting point
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @danrod - go for it :)
And please use a MR. - 🇩🇪Germany Anybody Porta Westfalica
@danrod I did some preparation work, please use the prepared MR for further fixes.
- 🇨🇦Canada danrod Ottawa
Thanks @anybody, I'll use the MR 90 instead, I was confused on which one should work on, this one or the issue
#3036556: Fix the issues reported by phpcs
- 🇩🇪Germany Anybody Porta Westfalica
@danrod: That's indeed confusing a bit, sorry.
I'd say:
- I'll merge the phpcbf fixes here, none of them are risky
- I'll update 📌 Fix the issues reported by phpcs RTBC with the fixes
- For PHPCS continue in 📌 Fix the issues reported by phpcs RTBC - as the issue already has a lot of feedback
- For the other fixes continue here
- 🇨🇦Canada danrod Ottawa
Thanks @anybody , I'll look on that now that I have some time (off work).
- 🇨🇦Canada danrod Ottawa
I fixed a bunch of PHPCS, CSPELL and STYLELINT issues today, I shall continue with the work tomorrow. A lot of work to do here.
Good night !
- 🇩🇪Germany Anybody Porta Westfalica
Thank you @danrod! Great!
Please note the comments over at 📌 Fix the issues reported by phpcs RTBC - 🇨🇦Canada danrod Ottawa
Yep, indeed this seems more complicated than expected, a lot of testing is needed.