Fix code style (phpcs. phpstan, styleint, cspell, eslint, ...)

Created on 19 August 2025, 6 days ago

Problem/Motivation

https://git.drupalcode.org/project/entity_browser/-/pipelines/576205 validation step should be green where possible to have a cleaner code-base for the future.

Thank you!

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

2.0

Component

Miscellaneous

Created by

🇩🇪Germany Anybody Porta Westfalica

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Anybody
  • 🇩🇪Germany Anybody Porta Westfalica
  • 🇨🇦Canada danrod Ottawa

    I'd like to work on this, I'll take it, if you don't mind.

  • 🇨🇦Canada danrod Ottawa
  • 🇩🇪Germany Anybody Porta Westfalica

    Also see 📌 Fix the issues reported by phpcs RTBC - maybe that's a good starting point

  • 🇩🇪Germany Anybody Porta Westfalica

    Thanks @danrod - go for it :)
    And please use a MR.

  • Merge request !90phpcbf fixes → (Merged) created by Anybody
  • 🇩🇪Germany Anybody Porta Westfalica

    @danrod I did some preparation work, please use the prepared MR for further fixes.

  • 🇨🇦Canada danrod Ottawa

    Thanks @anybody, I'll use the MR 90 instead, I was confused on which one should work on, this one or the issue #3036556: Fix the issues reported by phpcs

  • 🇩🇪Germany Anybody Porta Westfalica

    @danrod: That's indeed confusing a bit, sorry.

    I'd say:

    1. I'll merge the phpcbf fixes here, none of them are risky
    2. I'll update 📌 Fix the issues reported by phpcs RTBC with the fixes
    3. For PHPCS continue in 📌 Fix the issues reported by phpcs RTBC - as the issue already has a lot of feedback
    4. For the other fixes continue here
  • Pipeline finished with Skipped
    4 days ago
    #577536
    • anybody committed d9d5197e on 8.x-2.x
      Issue #3541968: Fix code style (phpcs. phpstan, styleint, cspell, eslint...
  • Merge request !97Resolve #3541968 "Further non phpcs fixes" → (Open) created by Anybody
  • 🇨🇦Canada danrod Ottawa

    Thanks @anybody , I'll look on that now that I have some time (off work).

  • Pipeline finished with Success
    4 days ago
    Total: 326s
    #577682
  • Pipeline finished with Success
    4 days ago
    Total: 340s
    #577691
  • Pipeline finished with Success
    4 days ago
    Total: 369s
    #577697
  • Pipeline finished with Success
    4 days ago
    Total: 316s
    #577715
  • Pipeline finished with Success
    4 days ago
    Total: 352s
    #577717
  • Pipeline finished with Success
    4 days ago
    Total: 343s
    #577740
  • Pipeline finished with Success
    4 days ago
    Total: 345s
    #577741
  • Pipeline finished with Success
    4 days ago
    Total: 339s
    #577746
  • Pipeline finished with Success
    4 days ago
    Total: 392s
    #577762
  • Pipeline finished with Success
    4 days ago
    Total: 347s
    #577766
  • Pipeline finished with Canceled
    4 days ago
    Total: 300s
    #577777
  • Pipeline finished with Canceled
    4 days ago
    Total: 237s
    #577784
  • Pipeline finished with Success
    4 days ago
    Total: 234s
    #577785
  • Pipeline finished with Success
    4 days ago
    Total: 227s
    #577791
  • Pipeline finished with Success
    4 days ago
    Total: 229s
    #577806
  • Pipeline finished with Canceled
    4 days ago
    Total: 239s
    #577821
  • Pipeline finished with Success
    4 days ago
    Total: 241s
    #577822
  • Pipeline finished with Success
    4 days ago
    Total: 257s
    #577826
  • Pipeline finished with Running
    4 days ago
    #577829
  • Pipeline finished with Canceled
    4 days ago
    Total: 251s
    #577835
  • Pipeline finished with Success
    4 days ago
    Total: 246s
    #577838
  • Pipeline finished with Success
    4 days ago
    Total: 249s
    #577841
  • Pipeline finished with Success
    4 days ago
    Total: 319s
    #577842
  • Pipeline finished with Success
    4 days ago
    Total: 297s
    #577856
  • Pipeline finished with Success
    4 days ago
    Total: 301s
    #577859
  • Pipeline finished with Success
    4 days ago
    Total: 251s
    #577865
  • 🇨🇦Canada danrod Ottawa

    I fixed a bunch of PHPCS, CSPELL and STYLELINT issues today, I shall continue with the work tomorrow. A lot of work to do here.

    Good night !

  • 🇩🇪Germany Anybody Porta Westfalica

    Thank you @danrod! Great!
    Please note the comments over at 📌 Fix the issues reported by phpcs RTBC

  • 🇨🇦Canada danrod Ottawa

    Yep, indeed this seems more complicated than expected, a lot of testing is needed.

  • Pipeline finished with Success
    2 days ago
    #579382
  • Pipeline finished with Success
    2 days ago
    #579395
  • Pipeline finished with Success
    2 days ago
    #579396
  • Pipeline finished with Success
    2 days ago
    Total: 426s
    #579504
  • Pipeline finished with Success
    2 days ago
    Total: 416s
    #579511
  • Pipeline finished with Success
    2 days ago
    #579517
  • Pipeline finished with Success
    2 days ago
    Total: 369s
    #579527
  • Pipeline finished with Failed
    1 day ago
    Total: 389s
    #579863
  • Pipeline finished with Success
    1 day ago
    Total: 328s
    #579882
  • Pipeline finished with Success
    1 day ago
    Total: 249s
    #579888
Production build 0.71.5 2024