- Issue created by @Anybody
- π¨π¦Canada danrod Ottawa
I'd like to work on this, I'll take it, if you don't mind.
- π©πͺGermany Anybody Porta Westfalica
Also see π Fix the issues reported by phpcs RTBC - maybe that's a good starting point
- π©πͺGermany Anybody Porta Westfalica
Thanks @danrod - go for it :)
And please use a MR. - π©πͺGermany Anybody Porta Westfalica
@danrod I did some preparation work, please use the prepared MR for further fixes.
- π¨π¦Canada danrod Ottawa
Thanks @anybody, I'll use the MR 90 instead, I was confused on which one should work on, this one or the issue
#3036556: Fix the issues reported by phpcs
- π©πͺGermany Anybody Porta Westfalica
@danrod: That's indeed confusing a bit, sorry.
I'd say:
- I'll merge the phpcbf fixes here, none of them are risky
- I'll update π Fix the issues reported by phpcs RTBC with the fixes
- For PHPCS continue in π Fix the issues reported by phpcs RTBC - as the issue already has a lot of feedback
- For the other fixes continue here
-
anybody β
committed d9d5197e on 8.x-2.x
Issue #3541968: Fix code style (phpcs. phpstan, styleint, cspell, eslint...
-
anybody β
committed d9d5197e on 8.x-2.x
- π¨π¦Canada danrod Ottawa
Thanks @anybody , I'll look on that now that I have some time (off work).
- π¨π¦Canada danrod Ottawa
I fixed a bunch of PHPCS, CSPELL and STYLELINT issues today, I shall continue with the work tomorrow. A lot of work to do here.
Good night !
- π©πͺGermany Anybody Porta Westfalica
Thank you @danrod! Great!
Please note the comments over at π Fix the issues reported by phpcs RTBC - π¨π¦Canada danrod Ottawa
Yep, indeed this seems more complicated than expected, a lot of testing is needed.
- First commit to issue fork.
- πΊπΈUnited States BenStallings
Hey sorry, @danrod, I just noticed this was still assigned to you. I hope my commits help you and don't hinder!
- π¨π¦Canada danrod Ottawa
No worries, @benstallings thanks for your help, I'm really stuck with some work stuff and I haven't had time to look in this one, probably I'll revisit this issue this week.
Please do continue with your work, if you have time, and thanks !