- Issue created by @rkoller
- ๐ฎ๐ณIndia jeeva r
I have found the solution for add % suffix to position field..
- ๐ฎ๐ณIndia divya.sejekan
Applied MR!7 , Patch gets applied cleanly.
% is displayed now as a suffix to Example Number Field.Steps Followed :
1. Install drupal, Install Skip to module
2. Go to /admin/config/user-interface/skiptoRTBC++
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
Thanks for the initial work! I've taken a look at MR7 and i am not sure if using javascript for adding a suffix is the right solution here. i guess the suffix itself could be solveable simply with plain php and the field api. by adding something like
'#field_suffix' => $this->t('percent', [], ['context' => 'skipto']),
to
$form['buttonSettings']['positionLeft'] = [
would solve things (except the wrong label for the number field, but that has to be fixed in ๐ Improve the microcopy on the settings page Active - still havent had the capacity to work on it). imho it is always preferable to go with to write something out instead of using a symbol like
%
for screenreader users. but talking of screenreader users, i've tested the solution in MR7 as well as my suggested one and neither is being announced when the numbers input gets into focus. I gotta do some more research if that is maybe a shortcoming in core in general. I'll set the issue back to NW. - ๐ฎ๐ณIndia jeeva r
@divya.sejekan, thanks reviewing my previous code.. Please review this changes too. I had attached the reference image for review the UI changes.