- Issue created by @rkoller
- 🇩🇪Germany rkoller Nürnberg, Germany
i've assigned the issue to myself and already created a MR.. Will work on an initial draft the next few days...
- Merge request !6early draft mainly being able to rebase the to be created MR → (Open) created by rkoller
- Merge request !9removing labels, themes, and restore settings pages and redo skipto help page → (Merged) created by rkoller
- Assigned to rkoller
- 🇩🇪Germany rkoller Nürnberg, Germany
ok MR9 is ready to review. had to hide MR6 cuz turned out previous changes prevented a rebase and fixing it locally was above my skill level so i did a fresh start and created MR9. Changes I did:
- changed the label for the setting page from skipto which might be too abstract for someone who has not installed the module nor has access to the extend page. instead of using the module name i went with
Skip links
, the thing the module is about. - i've then dropped the dedicated color theme, labels and restore settings pages so there is only a single settings page left. for the color themes i'Ve dropped the option to override the hex values and moved the select to the single skipto settings page. the option to override the labels i've dropped for now. it does not make any sense to provide that level of granularity. only downside i am not sure how translations should be handled with strings not available as form elements? and the option to restore the default settings is sort of unnecessary as soon as the option for altering the labels was removed. there is no danger that the user ends up with a broken setup.
- and i've updated the help page as well.
- changed the label for the setting page from skipto which might be too abstract for someone who has not installed the module nor has access to the extend page. instead of using the module name i went with
- 🇩🇪Germany rkoller Nürnberg, Germany
and added units to the description for the font size. an important detail, so far i've only added a numeric number and wondered why the font size got smaller even though a value of > 50 was entered. the number needs a unit like pixel or em then everything is working as expected.
- 🇩🇪Germany rkoller Nürnberg, Germany
pushed some changes based on the discussion with @mgifford today. the options on the "Scroll to target" select are not perfect. two options are identical to skipto upstream (fixed and popup-border), and two are more descriptive and verbose (static on top, visible on focus); fixed is ok but popup-border is still abstract and not self explanatory and clear.
- 🇬🇧United Kingdom the_g_bomb
Module and patch installs cleanly. I agree with the simplification of the module to remove some of the settings.
The module works well functionally, but I have made some comments on the renaming of the Settings etc, I think we should keep the term "SkipTo menu" rather than introducing "Skip links menu". Open to discussion, however.
- 🇬🇧United Kingdom the_g_bomb
Merged, we can fix any other issues in the follow-up issues.