- 🇩🇪Germany rkoller Nürnberg, Germany
a heavy +1 for bringing SkipTo to Drupal 11
- 🇬🇧United Kingdom the_g_bomb
This should be testable by using:
composer config repositories.skipto vcs https://git.drupalcode.org/issue/skipto-2634774.git composer require drupal/skipto:dev-2634774-port-to-drupal
- 🇩🇪Germany rkoller Nürnberg, Germany
one thing i wonder after changing the target in the title to drupal 11, would it make sense to support certain minor versions of drupal 10 as well? would simply have to expand the info.yml. i only dont know how to test which drupal 10 version would be supported as well?
- 🇬🇧United Kingdom the_g_bomb
Tested this and I think it looks good, there are a couple of things I spotted, but when I looked at:
https://skipto-landmarks-headings.github.io/page-script-5/ I can see them there too. If I get a chance, I will raise upstream.I think supporting ^10 would be a good idea as well.
- 🇩🇪Germany rkoller Nürnberg, Germany
pushed a commit extending the support to drupal 10 as well (tested on a drupal 10 install and all good) . as written on slack, i would created a release now and then discuss which issues need to be opened in the skipto drupal queue, the drupal core queue, and which in the skipto queue upstream. but i wouldnt make it a full release but rather an alpha1 release at first.
Automatically closed - issue fixed for 2 weeks with no activity.