- Issue created by @joel_osc
- 🇨🇦Canada smulvih2 Canada 🍁
Ahh cool, similar to the existing webform block for "Did you find what you were looking for?" but just ajaxed-in instead. Can test this out shortly today/tomorrow!
- 🇨🇦Canada joel_osc
Yes! I was working on it during our previous project now another client has requested it so here it is!! lol. Thanks!! One thing is that i have hard-coded the 'theme' options selector. I am not sure if we should make those more dynamic, but I think the list is fairly static. Cheers!
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This patch appears to be for
wxt_library
notwxt
. - 🇨🇦Canada joseph.olstad
ah ya, since it's a new file the MR branch patch will still apply against wxt_library
https://git.drupalcode.org/project/wxt/-/merge_requests/22.patch take this patch, apply it against wxt_library , should work.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Should this issue be moved to the
wxt_library
queue? - 🇨🇦Canada smulvih2 Canada 🍁
So only one small issue I can see:
public function defaultConfiguration() { return [ 'feedback_settings' => [ 'theme' => '', ], ]; }
But then in the form, we look for the default value like this:
empty($this->configuration['theme']) ? '' : $this->configuration['theme']
I think the defaultConfiguration() method should be:
public function defaultConfiguration() { return [ 'theme' => '', ]; }
Then the default value could simply be:
$this->configuration['theme']
- 🇨🇦Canada smulvih2 Canada 🍁
Oh actually maybe this was my oversight, I see how the field is nested under
['feedback_settings']
, so this actually might not be an issue. Will pull this into my local and test, then merge with 5.4.x and 6.1.x. Thanks!