- Issue created by @larowlan
- πͺπΈSpain isholgueras
I've tested it and it works well for me, test included.
The only issue I've found, that I guess only affects my environment and, even though, is not important as it's a test module is that I can't uninstall the module:
β°β ddev drush pmu xb_test_article_fields ββ― In ExceptionHandler.php line 52: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual tha t corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1 OFFSET 0' at line 5: SELECT 1 AS "expression" FROM "node_revision__field_xbt_path" "t" WHERE LIMIT 1 OFFSET 0; Array ( ) In StatementWrapperIterator.php line 113: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual tha t corresponds to your MariaDB server version for the right syntax to use near 'LIMIT 1 OFFSET 0' at line 5
I'll let others to test in case they also have the same issue with the uninstall.
Note: I haven't reinstalled the site.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Rebased this off 0.x which includes a conflict free approach from π Add e2e tests for telephone widget in page data form Active
- First commit to issue fork.
- πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
Even if the test is passing, when I select a value the select box "clears". We should show the selected option.
I'm guessing this is caused by the change in π Add e2e test and confirm support for date range date list widget Active , as @isholgueras reported this worked for him. - πͺπΈSpain penyaskito Seville π, Spain πͺπΈ, UTC+2 πͺπΊ
This was not catched on the tests. The select "clears" visually, but the data is stored and posted correctly, and after publishing and refreshing the page you can see the values you selected.
The cause is the options are casted as ints in
parseValue
atfunction-utils.js
. when the values on the select are strings. It happens too infield_xbt_daterange_datelist
.
Not sure how to fix this visually AND on the stored data, which requires ints. But hope this helps.
We would need some way to ensure in Cypress that the value selected is actually visible too. We are actually forcing the hidden select.// Radix renders these as a hidden element with a button to trigger, so // we have to use force. cy.get(`@${key}`).select(String(value), { force: true });
but we need to check the button label is changed too to the right value I guess?
- First commit to issue fork.