Coding standard

Hi Andres (@andresalvarez),

Thank you very much for raising this issue and for your interest for the Admin Toolbar module.

However, looking at the latest build with the validation jobs PHPCS and Stylelint :
https://git.drupalcode.org/project/admin_toolbar/-/pipelines/433361

It does not look like the project has any issue related with coding standards.

How and where did you get a report for these errors ? For which versions of the module, core and other components (PHPCS, Stylelint, etc....) ?
Did you try running the commands locally with the correct flags and parameters ?

If there isn't anything to be fixed here, it is unlikely these changes would be accepted.

However, if you are looking at helping the module maintainers, we would greatly appreciate some help fixing the PHPStan errors, see :
https://git.drupalcode.org/project/admin_toolbar/-/jobs/4468941

Or if you could please help testing the merge request at: 📌 GitlabCI: Fix ESLINT validation errors Active .

Any help, feedback and suggestions would be greatly appreciated.
Thanks in advance !

take the dev branch and run phpstan on it and get the error however I will continue with eslint. you mention

Thanks a lot Andres (@andresalvarez), it's greatly appreciated!

In general, we're basing the project's code validation on the jobs defined in Gitlab CI, see for example :
https://git.drupalcode.org/project/admin_toolbar/-/pipelines/433361

You should be able to see all the jobs for validation: PHPCS, PHPStan, ESLint, Stylelint, CSPELL and Composer.
The only jobs reporting issues at the moment are: ESLint and PHPStan (next minor).

Ideally, we would like to fix only the errors reported by these jobs.

Any help you could give us on the project will be very welcome!
Thanks in advance!

I kept working on it here in order to create a specific branch.

https://www.drupal.org/project/admin_toolbar/issues/3512602 📌 ESLint and PHPStan (next minor) settings. Active

dydave → closed merge request !119

Thanks a lot Andres (@andresalvarez).

Let's move the work over to 📌 ESLint and PHPStan (next minor) settings. Active .

Closing this issue as works as designed for now.
Thanks!