ESLint and PHPStan (next minor) settings.

Hi Andres (@andresalvarez),

Thanks a lot for creating this issue.

Could we please separate the work for these two jobs in different tickets?

Let's focus on the PHPSTAN errors in this ticket please.

Could you please revert the second commit in your MR?
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/120/di...

I think we could merge the first commit.

For ESLint: All the work has already been done in issue 📌 GitlabCI: Fix ESLINT validation errors Active : Could you please help us review and test the work from MR?
https://git.drupalcode.org/project/admin_toolbar/-/merge_requests/116

Thanks a lot for your help!

hello @DYdave

revert corrected

Great job Andres (@andresalvarez)! Thanks a lot for your help!

I've reviewed the changes with the following points:

1 - This change was introduced in change record:
CacheBackendInterface::invalidateAll() is deprecated →
See the examples of code changes before and after.

2 - Method CacheBackendInterface::deleteAll seems to have existed for a long time and more particularly on all version supported by the module: 9.5+

3 - PHPSTAN job is fixed and all the PHPUnit tests passed with the build 🟢
Build: https://git.drupalcode.org/project/admin_toolbar/-/pipelines/447025
phpstan (next minor): https://git.drupalcode.org/project/admin_toolbar/-/jobs/4647194

Therefore, the changes were merged at #7.

Latest build on 3.x seems to pass green 🟢
https://git.drupalcode.org/project/admin_toolbar/-/pipelines/447026

for all jobs, except ESLint, see 📌 GitlabCI: Fix ESLINT validation errors Active .

Marking issue as Fixed for now.

Thanks again Andres for your help and the great work!
Cheers!

Automatically closed - issue fixed for 2 weeks with no activity.