DRUPAL_OPTIONAL is defined in the system.module file.
Writing some Kernel tests, I found this error: Error: Undefined constant "Drupal\node\Entity\DRUPAL_OPTIONAL"
I eventually found the usage in \Drupal\node\Entity\NodeType, and when I temporarily modified it to say \DRUPAL_OPTIONAL, the error changed to: Error: Undefined constant "DRUPAL_OPTIONAL"
That's because it was a kernel test, and when I included the system module in my list of modules to add in the test, this error message went away (and was replaced by others, which is out of scope here... 😀)
When the system module is loaded, PHP eventually finds the correct constant in its namespace, but otherwise it's an error.
Also, this is a very minor issue to say the least, and brings our attention to 📌 Each class using DRUPAL_* constants from system.module should define its own constants Needs work where some refactoring is already underway.
But until that lands, this is still wrong and could maybe use some follow-through.
Modify NodeType to include the \ namespace, like this:
protected $preview_mode = \DRUPAL_OPTIONAL;
Active
11.1 🔥
node system
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
All the constants are written this way vs changing a single constant we should determine if all constants need to be updated.