- Issue created by @mcdruid
- π¬π§United Kingdom mcdruid π¬π§πͺπΊ
In general we'd use
expectException
in a test, but in this case we want to do some more checks after the exception is thrown.. so we have atry
/catch
instead.I am in two minds about having this very specific assertion about the
TypeError
:$this->assertStringContainsString('Cannot assign Drupal\Component\PhpStorage\FileStorage to property Drupal\Core\Config\StorageComparer::$targetCacheStorage', $e->getMessage());
That feels a bit like it might break in future, and we wouldn't necessarily care so long as the
TypeError
is still thrown.I'll leave it in for now.
Tests are passing on the MR.
- πΊπΈUnited States benjifisher Boston area
mcdruid β credited benjifisher β .
- πΊπΈUnited States greggles Denver, Colorado, USA
mcdruid β credited greggles β .
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
mcdruid β credited larowlan β .
- π¬π§United Kingdom mcdruid π¬π§πͺπΊ
Adding credit from the private security issue.
- First commit to issue fork.
- πΊπΈUnited States smustgrave
Going on a limb
Not 100% the ticket the fix was in but trying to go off the security release note.
Applied a super small change to move it from config to file group.
I believe the rest is covering the security concern, if I'm wrong I apologize now