Make the menu link form less verbose

+1 on removing it and simplify this UI. The description "The text to be used for this link in the menu." is not giving any extra context on top of the field label itself "Menu link title", which is self-explanatory already. And the same for the link itself.

I haven't checked the code, but seems simple enough to move it to RTBC anyway.

I reviewed the MR. I noted that the new test assertion will pass before and after the removal of the description in the MR. I have added an assertion that asserts that the page does not contain the text of the description. That should fail without this MR and pass with it.

Not sure if you guys use the pipeline 'test-only' test. You have to run it manually. It is a smart test. It will only run any test code in the MR, ie it does not run the 'fix' code. That way you can see if you have effective test coverage. Effective in the sense that the test will fail if applied to 11.x branch before this MR is merged. But pass when the MR is merged into it.

thanks for the extra test, in this case as this is a purely UI concern we do not need to make sure the text is not present. we removed it and keeping it in a test makes the string stay in the code. Kinda defeat the purpose of removing it :)

Committed and pushed 8357990ca57 to 11.x and 74321e2f21f to 11.1.x. Thanks!

nod_ → closed merge request !11015