Request for a -rc2 release

Created on 27 December 2024, 3 months ago

Problem/Motivation

Since the 2.0.0-rc1 release, a number of notable issues have been merged:

... in particular, I'm excited about the Drupal 11 support introduced in #3431529! (it remains open in case Project Update Bot makes some new suggestions)

May I respectfully request another Release Candidate (RC) release (i.e.: -rc2) with the new changes?

Feature request
Status

Active

Version

2.0

Component

Code

Created by

🇨🇦Canada mparker17 UTC-4

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @mparker17
  • 🇨🇦Canada mparker17 UTC-4

    Maintainers, please let me know if there is anything that I can do to help!

  • 🇨🇦Canada mparker17 UTC-4

    (meant to use an OL in the issue summary, not a UL)

  • 🇨🇦Canada mparker17 UTC-4

    (typo in issue summary, thanks for your patience with me!)

  • 🇪🇨Ecuador jwilson3

    Hi @mparker17.

    I'm curious have you tested 2.0.x-dev on your project?

  • 🇨🇦Canada mparker17 UTC-4

    Hi @jwilson3, I have, and it appears to work correctly!

    Here is what I did to test...

    1. Install ddev (I tested on version 1.24.1)
    2. Clone the module: git clone --branch '2.0.x' https://git.drupalcode.org/project/label_help.git && cd label_help
    3. Set up a test site for the module with the ddev/ddev-drupal-contrib plugin:
      1. ddev config --project-type=drupal --docroot=web --php-version=8.3 --corepack-enable --project-name=label-help - create a ddev project for testing the module
      2. ddev add-on get ddev/ddev-drupal-contrib && ddev start && ddev poser && ddev symlink-project - run the setup steps for the ddev/ddev-drupal-contrib addon
      3. Go to https://label-help.ddev.site/core/install.php in a browser. Note that I saw the Drupal 11.1.0 installer. Install the site with the "Standard" install profile.
    4. Set up the module for testing:
      1. Go to /admin/modules and install label_help
      2. Go to /admin/structure/types/manage/page/fields/node.page.body, and see the Label help message textarea. Set Label help message to This is a test of the label help message. Click Save settings.
    5. Test the basic module functions in Drupal 11:
      1. Go to /node/add/page. I see a Create Basic page form with an Title and Body field. The text This is a test of the label help message appears below the Body field label (please see the attached screenshot).
    6. Make sure there are no errors being logged:
      1. Go to /admin/reports/dblog to confirm that the module setup/testing did not result in any error messages related to this module.
  • 🇨🇦Canada mparker17 UTC-4

    Respectfully bumping this issue!

    (this module is my only blocker for a D10.4 -> D11.1 upgrade; thanks in advance for your understanding)

    Please let me know if there's anything that I can do to help!

  • 🇪🇨Ecuador jwilson3

    Thanks for the bump. I'll add to my list for this week. Apologies this dropped off my radar.

  • Assigned to jwilson3
  • Status changed to Fixed about 1 month ago
  • 🇪🇨Ecuador jwilson3

    I've released label_help:2.0.0-rc2 .

    Looking under the hood, the current codebase is a complex mess and has several limitations.

    Work is currently under way to bring Paragraphs support ( Add Label Help support for Paragraphs module fields Active ) and generally overhaul the module architecture ( 📌 Refactor Label Help to use hook_field_widget_WIDGET_TYPE_form_alter Active ), which I think is important for achieving a truly "stable" release, but I also don't want to give a false impression that getting to stable will not imply some potential bugginess, and since we're already at "Release Candidate" stage.

    I'm thinking there are effectively two routes:

    1. create a 2.0.0-rc3 containing the overhaul work; let it stabilize and then version off 2.0.0 with something everyone is more happy with.
    2. draw a line in the sand soon-ish with a 2.0.0 release (after the current rc2 has had time to be adopted and settled), and then start a 2.1.x branch and a 2.1.0-beta1 release for the overhaul.

    Any feedback on how to version such an overarching change are welcome. Thanks.

  • 🇨🇦Canada mparker17 UTC-4

    @jwilson3, apologies for the delay in replying: thank you very much for the new version!

    I haven't had a chance to test the changes in 📌 Refactor Label Help to use hook_field_widget_WIDGET_TYPE_form_alter Active , but in my opinion, there are enough changes to how the module works to warrant a 2.1.x or even 3.0.x branch (i.e.: Route 2 in your comment). (I can post this in 3495740 if you'd like :) ).

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024