Improve CI & Ddev integrations

Created on 26 May 2024, 7 months ago
Updated 10 June 2024, 7 months ago

Problem/Motivation

.gitlab-ci.yml was introduced while working on passing phpcs

For GitLab CI, there are several best practice improvements required:

  • Opt into previous major and previous minor tests.
  • Opt into next major tests.
  • Show environment variables, for convenience and we have no secrets to hide.
  • Show verbose log output from phpunit.
  • Fail on eslint, stylelint, phpstan, phpcs, and cspell.

For Ddev integrations, we want to be able to execute the same GitLab CI tasks from local, so we don't have to wait for Gitlab CI builds to run including:

  • ddev phpstan
  • ddev phpcs
  • ddev eslint
  • ddev stylelint
  • ddev cspell

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇪🇨Ecuador jwilson3

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jwilson3
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • 🇪🇨Ecuador jwilson3
    • ddev phpstan works.
    • ddev phpcs works.
    • ddev cspell works.

    The following needs work:

    1. ddev stylelint is reporting failures
      ❯ ddev stylelint
      yarn run v1.22.22
      $ /var/www/html/web/core/node_modules/.bin/stylelint '../modules/custom/**/*.css'
      
      ../modules/custom/label_help/css/claro.label-help.css
       22:3  ✖  Expected "flex" to come before "order"  order/properties-order
      
      ../modules/custom/label_help/css/seven.label-help.css
       21:3  ✖  Expected "flex" to come before "order"  order/properties-order
      
      2 problems (2 errors, 0 warnings)
      
      error Command failed with exit code 2.
      info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
      Failed to run stylelint : exit status 2
      
    2. ddev eslint seems to be broken
      $ ddev eslint
      /mnt/ddev_config/commands/web/eslint: line 16: cd: web/modules/custom/label-help: No such file or directory
      Failed to run eslint : exit status 1
      

      this needs an issue filed and fixed in upstream.

  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 8
    last update 7 months ago
    Waiting for branch to pass
  • Pipeline finished with Skipped
    7 months ago
    #182898
    • jwilson3 committed a57ab7c3 on 2.0.x
      Issue #3449923 by jwilson3: Improve CI & Ddev integrations
      
  • Status changed to Fixed 7 months ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024