- 🇪🇨Ecuador jwilson3
I've confirmed this is a problem only when the Link field is configured with the "Allow link text" option is set to "Disabled". Issue summary and title have been updated accordingly. I'll close ✨ Add Label Help support for "Link" type fields without link text Active as a duplicate.
- 🇪🇨Ecuador jwilson3
Bumping to Major since this is not an uncommon core field configuration.
- First commit to issue fork.
- Merge request !10Issue #2888604: Fix label help text render issue on link field. → (Merged) created by manish-31
- Status changed to Needs review
7 months ago 10:44am 27 May 2024 - 🇮🇳India manish-31
I have opened a Merge Request to fix this issue. Needs review.
The issue occurs because when we don't allow link text in link field it is no longer a "fieldset" so it skips the expected condition for link text.
Attached Screenshot after fix.
- Status changed to Needs work
7 months ago 12:05pm 27 May 2024 - 🇪🇨Ecuador jwilson3
Thanks @Manish-31 . I've tested to confirm this does indeed solve the issue.
The code review is good. However it need a grammar fix on the comment block in order to proceed with a commit.
I'll fix this myself and merge. Thanks again.
- Status changed to Needs review
7 months ago 12:11pm 27 May 2024 -
jwilson3 →
committed 376c641d on 2.0.x authored by
manish-31 →
Issue #2888604 by jwilson3, manish-31, cedewey, jasper22: Label Help...
-
jwilson3 →
committed 376c641d on 2.0.x authored by
manish-31 →
- Status changed to Fixed
7 months ago 12:47pm 27 May 2024 - 🇪🇨Ecuador jwilson3
Merged! Special thanks to @manish-31 for taking the time to debug and implement this one.
Automatically closed - issue fixed for 2 weeks with no activity.