- Issue created by @nicxvan
- Merge request !10614convert and move remaining core hook implementations → (Open) created by nicxvan
- 🇺🇸United States dww
Glad to see the rest of this committed. Thanks for opening this as a new issue.
- 🇺🇸United States smustgrave
With last nights commits appears to need a rebase.
if you are another contributor eager to jump in, please allow the original poster @nicxvan at least 48 hours to respond to feedback first, so they have the opportunity to finish what they started!
- 🇺🇸United States nicxvan
Yeah I had left this in needs work because I knew this needed the test fixes in the other issue.
- 🇺🇸United States dww
It's still
61 files +788 −683. Can/should we split this up further to be easier to review? Maybe media* and system their own issues, everything else in here? I think that'd get us closer to +/- 500 here. - 🇺🇸United States nicxvan
I'll split media and library and then system to their own
- 🇺🇸United States nicxvan
Ok I split system and the media modules out, those two issues are ready for review too.
- 🇺🇸United States smustgrave
Can the IS be updated with exactly what's being achieved here? Example the child issues marked what modules are being converted so it was super clear.
Thanks.
- 🇺🇸United States nicxvan
I added a list of the modules that I updated to the IS. Did you want more detail such as which changes are for each module?
- 🇵🇭Philippines ambot112
Thanks for your progress and effort @nicxvan for MR !10614. Looking forward for its release.
- 🇺🇸United States smustgrave
Did you want more detail such as which changes are for each module?
- no that's probably not needed, just needed a quick glance on what was done "several modules" was kinda vague.
Will try and find time this week to take a look, much larger then the others so takes a little longer.
- 🇺🇸United States nicxvan
Let's postpone this for a bit on 📌 Handle module preprocess functions Active