Navigation top bar is not rendered consistently

plopesc → changed the visibility of the branch 3491044-navigation-top-bar to hidden.

New MR following a different approach where context responsibility relies on the plugins instead the Top Bar itself.

Hello,

Tested and Verified on Drupal 11
Mr applied successfully
Attaching screenshot-

@sagarmohite0031, so is this RTBC?

Can the steps to reproduce be updated. Navigation_top bar isn't there anymore.

@smustgrave the navigation_top_bar module is still there but marked with hidden: true.

Sure

@plopsec pinged me about this one in slack. And as mentioned navigation_top_bar is now hidden. So re-tested

I did verify, with caching enabled, that on node/1 the top bar is not appearing

Before

After applying the patch

Toolbar is now appearing as expected.

1) Drupal\Tests\navigation\Functional\NavigationTopBarTest::testTopBarVisibility
Behat\Mink\Exception\ElementNotFoundException: Element matching xpath "//div[contains(@class, 'top-bar__content')]/div[contains(@class, 'top-bar__actions')]/button/span" not found.
/builds/issue/drupal-3491044/vendor/behat/mink/src/WebAssert.php:465
/builds/issue/drupal-3491044/core/modules/navigation/tests/src/Functional/NavigationTopBarTest.php:104
FAILURES!
Tests: 1, Assertions: 19, Failures: 1.
Exiting with EXIT_CODE=1

Test-only feature shows this too

Committed 79304e9 and pushed to 11.x. Thanks!

nod_ → closed merge request !10422