Deprecate node_add_body_field()

Would we also deprecate/remove the body field config itself then ((or more likely, move to standard/recipes)) or keep it for manually adding the body field?

@berdir we're trying to change it to text_long in 📌 Change automatic body field creation to use formatted text field instead of text_with_summary Active (which turns out to be hard) but ultimately I think this is something that recipes should handle - shipping a content type (that needs a body field) is recipe-ish already, and recipes can also handle the create-if-not-exists logic that removing the default config would require.

Rebased and tidied up a lot of duplication in tests by using ContentTypeCreationTrait, also added a CR.

There were 2 spots in runtime code that are still using this function:
- NodeTypeForm - only using for the testing profile, this should definitely just be removed. We don't want test code in runtime code.
- The EntityNodeType migration destination plugin - I've replaced this with the contents of node_add_body_field

So the outcome here is a little bit more duplication (between the test trait and migration plugin) but I think that's ok.

Looks like only 6 tests relied on the NodeTypeForm bits https://git.drupalcode.org/issue/drupal-3489266/-/pipelines/463009/test_...

Other failures in that pipeline are random afaict

Last failure is in Nightwatch and for once doesn't look like a random fail, I'm assuming we need to add a step to it to create the body field

https://git.drupalcode.org/issue/drupal-3489266/-/jobs/4842498

Whatever we decide here we should do the same for block_content as pretty sure we got copy and paste code with the same stuff.

Maybe we need some default config in the testing profile for nightwatch? Or is there a utility call to add a field?

Postponing on converting those tests to WebDriver tests.

#13 📌 Deprecate node_add_body_field() Active So you've decided to drop the Nightwatch test?

@spooky063 that's right, it's probably the most straight forward and best overall solution IMO. Nightwatch tests are already on the chopping block, and since it's only 2 tests that can both be more easily tested in PHP (WebDriver) tests it makes sense to move those anyway.

Otherwise we need to either
a) copy the same field creation code into NodeTypeForm again, we don't want to tie that form to the testing profile anyway so this wouldn't do, or
b) add more Nightwatch steps to the 2 tests, further extending the already lengthy test case. That would then need to be ported again when Nightwatch is eventually replaced.

I looked at adding default config to the testing profile but the profile is specifically very barebones so that didn't feel right either.

One of the issues is already up for review with more detail so feel free to review if you can :)

Whatever we decide here we should do the same for block_content as pretty sure we got copy and paste code with the same stuff.

We should probably also make the body field creation reusable in that case and use it in the NodeTypeCreationTrait