Deprecate block_content_add_body_field

We should just wait until the node issue is done so we can reuse the trait here https://git.drupalcode.org/project/drupal/-/merge_requests/11194/diffs#8...

Sure, going to keep assigned to me then as I hope the blocker will land soon

smustgrave → closed merge request !12702

Blocker is in, I kept as removed in 12 as that was the same as node_add_body_field

This is looking great, I tweaked the CR slightly and added the API changes to the IS.

Mostly looks good. 1 minor question in the MR about if this is disruptive enough to defer removal for D13.

Hah, that's what #9 said. But I think that previous removal was in 11.2 so the rules were different back then...

@dww I think the rationale for removing in D12 is explained in #9

Yea don’t know best rule of thumb but the node-body ticket was set to 12 so just copied that

FWIW, while this is the same concept as node types technically, the situation and arguments for removing it (or not) are a bit different here:

For node types, the majority of sites at this point use alternative means to create the content: paragraphs, layout builder, experience builder. That's less of an issue. However, unlike node types, of which most need some kind of content, you're much less likely to need a second block type that has a body field. Also, I was surprised to find out that this does in fact also use text_with_summary, which makes even less sense here, because blocks don't really have a use case for a summary/teaser.

So I think it makes sense to remove this as well, but I think the issue summary should explain this better than "because node does it too".

Also, as commented in 📌 Stop automatic storage creation of body field Active , I don't think this should block that. Either it should have it's own issue doing that or we should do it all here, but then we'd want to postpone this on that, so that we can copy the approach and figure out what needs to be done exactly first with node.

Tried to tweak the summary some. Going to keep the scope as is and not remove the storage file just yet as it will overly complicate this one.

Updated the issue summary with a bit more info.

This looks fine to me. Do we need a block-specific follow-up to also look at removing the default field config (that still uses text_with_summary) or is that covered somewhere in the general 'deprecate text_with_summary' metas somewhere?

Agreed that the deprecation should be fine for 12.x, this is only used in one place in core outside tests and the usage inside tests is pretty minimal.

Committed/pushed to 11.x, thanks!

catch → closed merge request !12779

Tagging for follow-up, if there's an existing issue, would be good to add it to the related issues.

Opened 📌 Remove default field config now that we don't create body field by default Active

Should this issue be retitled as it sounds like we haven't removed the auto creation yet?