- Issue created by @just_like_good_vibes
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
If there is no specific requirements that can't be done with the .info.yml file of the main module, then a composer.json file is not needed as there is one automatically generated or at least metadata are exposed by the drupal.org composer facade https://www.drupal.org/project/project_composer →
And re-reading the description, it seems that sub-modules requirements are also detected automatically.
-
mogtofu33 →
committed 73feab72 on 1.0.x
Issue #3488558 by just_like_good_vibes, grimreaper, mogtofu33: Add a...
-
mogtofu33 →
committed 73feab72 on 1.0.x
- 🇫🇷France mogtofu33
Ok, so for now, just added a ui_icons_font for the dompdf dependency, let see if we really need one main.
- 🇫🇷France just_like_good_vibes PARIS
Hi grimreaper,
yes i understand your point.
but it's better to have one for several reasons :
- one can easily manage all metadata, as seen in the composer world (description, licence, suggests or whatever)
- when in "development mode", i personally use composer path repositories to all dev projects from my drupal projet main composer.json; I manually manage for exemple ui_icons in a directory where i can switch for a git fork branch to the main git...so on. and my project is installing ui_icons from that local directory with a symbolic link (composer path repo). whitout composer.json at root for ui_icons, it makes it harder to have such nice usage - 🇫🇷France Grimreaper France 🇫🇷
I understand that you have your development habits.
I don't think development habits should be reflected in a repository. For example on another level, I don't put a gitignore with IDE related stuff in my repositories, I have a global .gitignore.
But that's personal.
I would say 2 things :)
- let the maintainers decide :p
- I also need a composer.json in ✨ Linkit with attributes with icon Active ;) (for the require-dev) - 🇫🇷France Grimreaper France 🇫🇷
As now there is composer.json, should the issue be marked as fixed by a maintainer?
- 🇫🇷France Grimreaper France 🇫🇷
There is a composer.json now with ✨ Linkit with attributes with icon Active merged.
Automatically closed - issue fixed for 2 weeks with no activity.