- Issue created by @Grimreaper
- Merge request !48Issue #3482495 by grimreaper: Linkit with attributes with icon → (Merged) created by Grimreaper
- First commit to issue fork.
- 🇫🇷France Grimreaper France 🇫🇷
MR rebased. Thanks for the CI changes. Nice to see a green pipeline.
- 🇫🇷France Grimreaper France 🇫🇷
When retesting, I found 🐛 regression with ui_icons_menu Active .
And also I rebased and provided a linkit formatter.
2 new code review comments to discuss.
Then if we are ok I will provide a test if possible.
- 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks for the update.
I also pushed some stuff after review.
4 remaining points:
- config schema to fix
- accessibility discussion
- default rendering
- minor stuffAttaching my tests.
-
mogtofu33 →
committed 7e3bbcc6 on 1.0.x authored by
grimreaper →
Issue #3482495 by grimreaper, mogtofu33: Linkit with attributes with...
-
mogtofu33 →
committed 7e3bbcc6 on 1.0.x authored by
grimreaper →
Automatically closed - issue fixed for 2 weeks with no activity.