Resolve PHPStan-Strict errors: class.nameCase

Only temporarily postponing pending feedback on 📌 Resolve issues exposed by PHPStan Strict Active

If we decide there no harm in merging these we can put back into review and I'll put top of my list to review. Just want to make sure they'll be accepted first.

I have to agree with @dpi's summary in #3487269-9: [meta] Resolve issues exposed by PHPStan Strict with all rules off (misc and core configuration changes) → , these can and should be fixed regardless if phpstan or phpstan-strict are tools we use or don't use.

I've reviewed the MR and noted all changes are straightforward, and correctly match the expected class names. I also ran phpstan with checkInternalClassCaseSensitivity: true (without the strict package) and verified the same 8 violations were reported.

Have updated the IS with steps to reproduce not requiring the strict package.

Shouldn't we then enable the checkInternalClassCaseSensitivity parameter in phpstan.neon so to prevent regressions?

Yes, let's prevent regressions. Is there a reason not to enable checkInternalClassCaseSensitivity?

Added the param

Looks good.

Looks great!

larowlan → closed merge request !10169

Committed to 11.x - thanks!

Automatically closed - issue fixed for 2 weeks with no activity.