Create LessonStatus class interface

Created on 3 November 2024, 13 days ago

Problem/Motivation

In order to complete #3477461 - Create interfaces 📌 Create interfaces Active
we need to implement class interfaces for LessonStatus.

API changes

Adding class interface for LessonStaus

📌 Task
Status

Active

Version

1.0

Component

Other backend

Created by

🇩🇪Germany Istari

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

  • API clean-up

    Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @Istari
  • Pipeline finished with Success
    13 days ago
    Total: 290s
    #328137
  • 🇮🇳India ankitv18

    Hi @mysdiir,
    I've left few comments on the MR, please check.

  • 🇵🇱Poland Graber

    Also make sure to merge latest 1.0.x to your branch (there may be conflicts as well), I probably added some methods as a part of 📌 Get 1.0.x linting pipeline steps to green Active

  • Pipeline finished with Failed
    9 days ago
    #331237
  • Pipeline finished with Failed
    9 days ago
    #331244
  • 🇩🇪Germany Istari

    It seems the pipeline failure comes from a deprecated group.membership_loader service.
    I took a look at my code I am not using group.membership_loader so I am unsure where whis error comes from, how it affects my branch and how I can fix it.

  • 🇵🇱Poland Graber

    The fact that the automated tests pass on 1.0.x and fail on this feature branch means that the changes on this feature branch cause the tests to fail. I'd try to implement your changes 1 by 1 and run automation afterwards if you don't have any other ideas.

  • 🇵🇱Poland Graber

    Also.. did you merge latest 1.0.x to your feature branch as instructed in #8?

  • 🇩🇪Germany Istari

    I did it in 20199c99
    but I'm unsure it 1.0.x was merged into it.
    If not then assign me and I will merge it asap

  • 🇵🇱Poland Graber

    I cannot assign you, you need to do it yourself.

  • Pipeline finished with Failed
    8 days ago
    Total: 197s
    #333247
  • 🇩🇪Germany Istari

    Remerged 1.0.x into lms-3485267

    The phpunit pipeline error showing the deprecated usage of group.membership_loader still persists.

    Just to be sure:
    Before the branch gets as last attempt merged into 1.0.x (main branch) by (co-)maintainers, I need to make sure all new changes in 1.0.x (main branch) are merged into my working branch?

    Because the reason for the second merging needed to be done was that there were new changes in 1.0.x that didn't exist in my branch, which would have caused a merge conflict?

    So what I understand so far is, why it is importan to resolve the issue within a certain timeframe to avoid unnecessary merge conflicts.

    Also just an to get it for future works on lms or contrib in general.

  • 🇩🇪Germany Istari

    edit: cannot assing Graber

  • 🇵🇱Poland Graber

    Don't assign me, until pipelines pass it's a "needs work".

    So what I understand so far is, why it is importan to resolve the issue within a certain timeframe to avoid unnecessary merge conflicts.

    Yes, it happens, better not to let the issues stay in progress for too long or to choose something not related to other work.

Production build 0.71.5 2024