- Issue created by @Istari
- ๐ฎ๐ณIndia ankitv18
Hi @mysdiir,
I've left few comments on the MR, please check. - ๐ต๐ฑPoland Graber
Also make sure to merge latest 1.0.x to your branch (there may be conflicts as well), I probably added some methods as a part of ๐ Get 1.0.x linting pipeline steps to green Active
- ๐ฉ๐ชGermany Istari
It seems the pipeline failure comes from a deprecated
group.membership_loader
service.
I took a look at my code I am not usinggroup.membership_loader
so I am unsure where whis error comes from, how it affects my branch and how I can fix it. - ๐ต๐ฑPoland Graber
The fact that the automated tests pass on 1.0.x and fail on this feature branch means that the changes on this feature branch cause the tests to fail. I'd try to implement your changes 1 by 1 and run automation afterwards if you don't have any other ideas.
- ๐ต๐ฑPoland Graber
Also.. did you merge latest 1.0.x to your feature branch as instructed in #8?
- ๐ต๐ฑPoland Graber
I cannot assign you, you need to do it yourself.
- ๐ฉ๐ชGermany Istari
Remerged 1.0.x into lms-3485267
The
phpunit pipeline error
showing the deprecated usage ofgroup.membership_loader
still persists.Just to be sure:
Before the branch gets as last attempt merged into 1.0.x (main branch) by (co-)maintainers, I need to make sure all new changes in 1.0.x (main branch) are merged into my working branch?Because the reason for the second merging needed to be done was that there were new changes in 1.0.x that didn't exist in my branch, which would have caused a merge conflict?
So what I understand so far is, why it is importan to resolve the issue within a certain timeframe to avoid unnecessary merge conflicts.
Also just an to get it for future works on lms or contrib in general.
- ๐ต๐ฑPoland Graber
Don't assign me, until pipelines pass it's a "needs work".
So what I understand so far is, why it is importan to resolve the issue within a certain timeframe to avoid unnecessary merge conflicts.
Yes, it happens, better not to let the issues stay in progress for too long or to choose something not related to other work.
- ๐ต๐ฑPoland Graber
I think thatโs done now as a part of phpstan fixes. Closing.