- Issue created by @Graber
- 🇩🇪Germany Istari
mysdiir → made their first commit to this issue’s fork.
- 🇩🇪Germany Istari
I started building the interfaces (the first half) and wanted to mention a few things:
- to leave the
protected
classesprotected
, I would consider not to create interfaces for them, due to the nature of interfaces and the result that interfaces can't implement protected methods without extending the logic.- I noticed that there are a few redundant class and interface methods so I would consider in creating like a lms base class and something like a lms base interface, that can be further extended and be provided with more custom related logic. But this could also be outsourced into later issues
Its currently WIP, but I will finish it during the weekend.
- 🇩🇪Germany Istari
regarding
Lesson::getLessonActivities()
parameter$full
-> what exactly is meant with that parameter? - 🇵🇱Poland Graber
I think it’s a leftover from Opigno, it’s about loading full entities vs just some data.
I don’t think it’s used that way (if at all) anymore. - 🇵🇱Poland Graber
Ok, getLessonActivities is not used anywhere. You can just remove unused methods.
- 🇵🇱Poland Graber
Pls add a comment here after you make changes (set it back to review), otherwise I don’t get notified.
Still a few unresolved threads.
- 🇵🇱Poland Graber
@mysdiir
This turned out to be quite a hard issue, see my last commit (https://git.drupalcode.org/project/lms/-/merge_requests/33/diffs?commit_...) for things that needed fixing and cleaning up so you'll get the idea for future tasks. Could you finish with the LessonStatus and LessonStatusInterface? - 🇵🇱Poland Graber
I'm merging this so there are no conflicts with other work. We'll need a follow-up for the LessonStatus class interface.
Automatically closed - issue fixed for 2 weeks with no activity.