- Issue created by @lavanyatalwar
- First commit to issue fork.
- Merge request !27Issue: #3484545: Changed some 'giftcard' to 'gift card' and 'giftcards' to 'gift cards' → (Merged) created by nexusnovaz
- 🇬🇧United Kingdom nexusnovaz
Hi,
I believe I got quite a few of them, though its actually rather difficult to tell. For example: "The giftcard storage schema." should this be changed or kept the same? Same with "Access control handler for giftcard transactions.". I'm going to mark as needs review for the words, im unsure why the tests are failing. Something about views page 2 schema. If this isn't the correct workflow please let me know and ill make a note for future.
I also noticed another issue which seems out of scope for this ticket but im unsure how to go about creating a bug/ticket for it. In src/Entity/GitftcardType:76 there is `The the` in a comment.
Thanks
- 🇩🇪Germany Anybody Porta Westfalica
Thanks @nexusnovaz re "The the": Simply fix it here.
In both cases you mention regarding the module name - leave it as is, as I think this is more focused on the module name then on the regular term.
- 🇩🇪Germany Anybody Porta Westfalica
@nexusnovaz I reviewed the changes and it looks really good. Just found some remaining strings in the tests, for example:
- tests/src/Functional/GiftcardAdminTest.php
and others. Could you check them once more, please?
- First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
Great! Thanks! I'll merge this one now. Didn't find any other relevant occurencies.
-
anybody →
committed 9e58ec98 on 2.x authored by
nexusnovaz →
Issue #3484545 by nexusnovaz, ankitv18, anybody, lavanyatalwar: Unify '...
-
anybody →
committed 9e58ec98 on 2.x authored by
nexusnovaz →
Automatically closed - issue fixed for 2 weeks with no activity.