- Issue created by @Liam Morland
- First commit to issue fork.
- First commit to issue fork.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
The easiest solution may be to pin the version of the template. It could be pinned to the latest version of template 1.5.x.
- 🇧🇬Bulgaria pfrenssen Sofia
Pinning the version would be a workable temporary solution, but we would then still have to update the template later.
It looks like the failures are just because in the test fixes introduced in ✨ Drupal 11 compatibility fixes for webform Active we are not making a distinction between Drupal 11.0 and 11.1. Now tests are running on Drupal 11.0.5, but some of the tests are checking features introduced in 11.1 (like ✨ Continuation Add Views EntityReference filter to be available for all entity reference fields Needs work and 📌 Use easily recognizable date format RTBC )
I'm hoping that fixing this will turn the pipelines green.
-
liam morland →
committed 1b0e5e42 on 6.3.x authored by
pfrenssen →
Issue #3481554 by pfrenssen: Correct target version detection in tests...
-
liam morland →
committed 1b0e5e42 on 6.3.x authored by
pfrenssen →
-
liam morland →
committed 2ad1b73c on 6.3.x authored by
pfrenssen →
Issue #3481554 by pfrenssen: Update testing config to accommodate...
-
liam morland →
committed 2ad1b73c on 6.3.x authored by
pfrenssen →
-
liam morland →
committed 1b0e5e42 on 6.x authored by
pfrenssen →
Issue #3481554 by pfrenssen: Correct target version detection in tests...
-
liam morland →
committed 1b0e5e42 on 6.x authored by
pfrenssen →
-
liam morland →
committed 2ad1b73c on 6.x authored by
pfrenssen →
Issue #3481554 by pfrenssen: Update testing config to accommodate...
-
liam morland →
committed 2ad1b73c on 6.x authored by
pfrenssen →
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Tests were passing but now they are failing again. The "Previous major" tests are passing but not the current version tests.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
The test failures are related to
ckeditor
so it is likely that they would be fixed by completing 📌 Remove legacy ckeditor from codebase. Active . - 🇮🇳India kulpratap2002
@liam morland The following issue is in RTBC. Please review and merge it so we can proceed with the current issue.
📌 Remove legacy ckeditor from codebase. Active - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Test are not passing again.
- First commit to issue fork.
- 🇺🇸United States jrockowitz Brooklyn, NY
Let's see if we can get the tests to pass and potentially tag a beta release for Drupal CMS.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Yes, I was thinking it was time to tag an alpha once tests pass.
If this test was converted to XPath, checking for the needed elements and attributes instead of a specific string, it would probably work without the need for
version_compare()
. - 🇺🇸United States jrockowitz Brooklyn, NY
As soon as this test passes and I merge the change, tagging an alpha would be great. For now, I want to avoid any code refactoring.
For Drupal CMS, tagging a beta by 12/8 would be ideal. I will review tickets to see if anything is required for a beta release.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I switched the test to XPath and now the one test passes on all versions.
I initially included a test for the contents of the
data-drupal-states
attribute, but that didn't work. I suspect we don't need to test that anyway since it is a Drupal internal thing.Unless you disagree with this approach, I will merge and tag an alpha today. If no release-blockers appear in two weeks, we can have a beta on December 6.
- 🇺🇸United States jrockowitz Brooklyn, NY
Let's merge it and tag an alpha release.
-
liam morland →
committed 3f6ff64a on 6.3.x authored by
jrockowitz →
Issue #3481554: Convert test to XPath
-
liam morland →
committed 3f6ff64a on 6.3.x authored by
jrockowitz →
-
liam morland →
committed 3f6ff64a on 6.x authored by
jrockowitz →
Issue #3481554: Convert test to XPath
-
liam morland →
committed 3f6ff64a on 6.x authored by
jrockowitz →
Automatically closed - issue fixed for 2 weeks with no activity.
- Merge request !575Issue #3481554: Convert ::testImageSelect() test to XPath → (Merged) created by Liam Morland
-
liam morland →
committed cfae367e on 6.3.x
Issue #3481554: Convert ::testImageSelect() test to XPath
-
liam morland →
committed cfae367e on 6.3.x
-
liam morland →
committed cfae367e on 6.x
Issue #3481554: Convert ::testImageSelect() test to XPath
-
liam morland →
committed cfae367e on 6.x
- Status changed to Fixed
2 months ago 5:04pm 24 December 2024 Automatically closed - issue fixed for 2 weeks with no activity.