- Issue created by @mably
- Merge request !58Issue #3478862 by mably: Drupal 11 compatibility fixes for conditional_fields → (Closed) created by mably
- 🇨🇦Canada joseph.olstad
@mably MR passes testing.
The MR patch is here:
https://git.drupalcode.org/project/conditional_fields/-/merge_requests/5... - 🇭🇺Hungary nagy.balint
Any news on this issue?
What do we need to commit this?
- 🇮🇳India rahul1707
Tested MR !58 changes in Drupal 10.3 and Drupal 11, functionality is working fine and also upgrade status is showing no problem found.
Changing status to RTBC.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
Why do we have a duplicate issue created a month ago while there was already one existing with contribution of original maintainers of this project? (not talking about me here)
Thanks for all the efforts and any contribution is very much appreciated to move on. But please let us keep things sorted and do not let us outframe efforts in other issues already made and please MR this here if required into the former compatibility issue exisiting already since March of this year.
Million thanks! And sorry for any inconveniened feelings about it. But it would not be very nice regarding the previous issue work done. This is why we usually follow the rule to mark the newer as duplicate of the former. This way we do not loose track of overlapping fixes and do not loose track of credits on efforts in the issues.
- 🇫🇷France mably
Ok for me, as long as we get a Drupal 11 release quick.
That was a lot of hard work though.
- 🇫🇷France mably
Code pushed to original issue 📌 Automated Drupal 11 compatibility fixes for conditional_fields Needs review .
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
That was a lot of hard work though.
Indeed! Very impressive and very much appreciated. It was hard for me to make this very unsatisfying step. But it is a common procedure on Drupal to prevent credit and fix overlapping issues. And I am sorry for the frustration. I recommend to use the issue search before starting an new issue. Or if you feel the original issue is not going in the right direction or too slow, to ping contributors or to discuss in the issue how to move on. I think your contributions are awesome and can move things forward a lot. +1 And your thoughts will weight. So I don't want to demoitilize you in any way and hope you keep up your awesome work! Thanks for pushing into the previous issue!
- 🇫🇷France mably
You're welcome :)
I guess that's the "Automated" part of the other issue that got me wrong.