Fix MissingParamType in core/lib/Drupal/Core

Nightwatch seems random.

Reviewed the code changes and make sense to me. Not sure how else to review

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

A simple rebase.

A simple rebase, leaving at RTBC

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Another simple rebase

I was expecting to see a change to phpcs.xml.dist here - is that missing?

While that is normally true, I often found that difficult for this sniff. One reason is that I found it easier to do all the Database related fixes in a separate issue, because it was easier to think about that at one time. That is in 📌 Fix MissingParamType for Database related Active where the phpcs.xml.dist is updated. But for this issue some of the files in core/lib/Drupal/Core are database related, so fixed in the other issue.

And since this issue was created some more violations have crept in. I see some about Hooks and in Utilities. For me, I would rather get this piece in, since it has gotten this far, and pick up the stragglers in the parent.

Fine by me, restoring RTBC

Committed to 11.x - thanks!

larowlan → closed merge request !9722

Found an error in the type declaration of form_id in \Drupal\Core\Form\FormValidatorInterface::validateForm. The commit contains array but it should be string.

Found this by a failing PhpStan test for next minor in the ECA project: https://git.drupalcode.org/project/eca/-/jobs/3884594

I hope it's OK to re-open this one, or should I create a follow-up issue?

@jurgenhaas better to do these things in a separate followup issue.

Automatically closed - issue fixed for 2 weeks with no activity.

There is also an issue with EntityStorageInterface
https://github.com/mglaman/phpstan-drupal/pull/827

Created follow-up issue