Drupal\Core\Validation\ExecutionContext::addViolation(): Argument #1 ($message) must be of type string, null given,

here is batch fix

@amer cloudy

You need to keep the headline and custom text below the headline.

As per comment #29 created MR and done the Unit testing on ProtectedUserFieldConstraintValidatorTest.php

On the file, ProtectedUserFieldConstraintValidatorTest.php will have logic for passing messages and without messages for the Violation. So any additional test case hope not required.

if ($name) {
      $context->expects($this->once())
        ->method('addViolation')
        ->with($constraint->message, ['%name' => $name]);
    }
    else {
      $context->expects($this->never())
        ->method('addViolation');
    }

This patch will allow null values for $message and replace them with a default message ('An error occurred.') if null is encountered, ensuring the method behaves as expected.

arunkumark → changed the visibility of the branch 3477609-drupalcorevalidationexecutioncontextaddviolation-argument-1 to hidden.

arunkumark → changed the visibility of the branch 3477609-custom-validation-no-message to hidden.

arunkumark → closed merge request !9752

arunkumark → changed the visibility of the branch 3477609-custom-validation-no-message-fix to hidden.

Please read the tags before review

I have updated the issue summary. There is now a merge request in place. There is a fix and test coverage in place so I am changing the status to 'Needs review'.

Issue summary should follow standard template. Example the section for proposed solution is missing.

The MR doesn’t have a test coverage and there’s also 2 open. One should be hidden or highlighted in the proposed solution section which MR is to be reviewed

oily → changed the visibility of the branch 3477609-custom-validation-no-message-d11 to hidden.

oily → changed the visibility of the branch 3477609-custom-validation-no-message-d11 to active.

@smustgrave Thank you. I think you can hide branches. I think I have hidden the 'old' branches now. I cannot see a way to hide MR's so there are > 1 showing.

For test coverage, I guess the following would work.

• Create a new test module or use an existing one
• Inside it, create a custom validator containing without a message parameter
• Create a unit test to mock the custom validator class
• Test that a generic message is returned by the class
• Test that no exception is thrown