- Issue created by @sunil jolapara
- Merge request !1Resolve #3477525 "Fix the phpcodesniffer issues" ā (Open) created by sunil jolapara
- šŗšøUnited States sunil jolapara 3265 Summitrun Drive, Independence, KY, 41051
- š®š¹Italy apaderno Brescia, š®š¹
The issue summary for PHP_CodeSniffer issues should always show the report given from PHP_CodeSniffer and the arguments passed to
phpcs. - šµšPhilippines cleavinjosh
Hi @sunil jolapara,
Thank you for providing an MR. I applied MR!1, it was applied smoothly and fixed all the phpcs issues.
ā user_logout_shortcut git:(1.0.x) curl https://git.drupalcode.org/project/user_logout_shortcut/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2825 0 2825 0 0 3888 0 --:--:-- --:--:-- --:--:-- 3885 patching file README.md patching file css/user-logout.css patching file src/Controller/UserLogoutShortcutController.php ā user_logout_shortcut git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml user_logout_shortcut ā contrib git:(main) āThank you.
- Merge request !2Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix ā (Open) created by cleavinjosh
- šµšPhilippines cleavinjosh
cleavinjosh ā changed the visibility of the branch 3477525-phpcs-issues to hidden.
- Issue was unassigned.
- Status changed to Needs review
4 months ago 5:33am 2 December 2024 - š®š³India chandansha
I have tested MR 1 using @cleavinjosh given command i find below issue.
FILE: /home/chandansha/docker/d9contro/web/modules/custom/user_logout_shortcut-3477525/README.md ------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------------------------ 18 | WARNING | Line exceeds 80 characters; contains 93 characters ------------------------------------------------------------------------------------------------ FILE: /home/chandansha/docker/d9contro/web/modules/custom/user_logout_shortcut-3477525/css/user-logout.css ---------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------- 24 | ERROR | [x] Each style definition must be on a line by itself ---------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------- Time: 65ms; Memory: 10MBi move it to Need Work
Thanks!! - š®š³India kulpratap2002
Gitlab CI does not report issues for the README.md file and see #12 @avpaderno told that these changes not required by gitlab ci.
- š®š³India chandansha
@kul.pratap Thanks For pin I have tested it on my local. Now if we have to check only pipeline then its successfully pass.
I move it to RTBC
Thanks!! - š®š¹Italy apaderno Brescia, š®š¹
The only file with PHP_CodeSniffer errors is the src/Controller/UserLogoutShortcutController.php file. The merge request changes two files instead of one.
Furthermore, the existing branch is no longer supported. Before doing any change, either the branch should be changed to require a supported Drupal core version, or a new branch should be created for a supported Drupal core version.