Enforce ESLint and Prettier on Cypress tests

📌 CI: improve UI-related CI jobs:`UI eslint` obscures TypeScript Compiler errors, `npm run build` runs too late Needs review was the last issue that touched this area in a significant way — you'll probably find helpful pointers there :)

Let's land this!

Let's rename the directory to tests, please: ui/cypress → ui/tests. That is more conventional, and it's how people would look for tests. I think the current structure under that folder is fine, I don't see the need to have a subdirectory named cypress.

Also, when I tested the changes locally, I got many ESLint errors and required formatting changes when running npm run lint:eslint and npm run format. Let's make sure those are all gone before we merge the MR, otherwise we will break all MRs that merge in upstream code.

Will continue this

Postponing this to after 🌱 [Proposal] A different approach to the iFrame preview interactions Active is in since that touches many many Cypress files and would make sense to fix the errors the eslint-cypress plugin surfaces after that's in to avoid extra work.

🌱 [Proposal] A different approach to the iFrame preview interactions Active has landed!

A lot of the cypress eslint errors were for this rule: cypress/unsafe-to-chain-command. https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/unsafe-to-chain-command.md

This was good reading since the incorrect way seems very intuitive to me but turns out it's not recommended! :
https://docs.cypress.io/app/core-concepts/retry-ability#Actions-should-be-at-the-end-of-chains-not-the-middle

I went through all changes and approved the MR. Thanks for the hard work on this, everyone!

We're blocked on a code owner approval for the changes in gitlab-ci.yml. I naïvely thought I could temporarily add myself as a code owner, and give the approval, but it didn't work. (Makes sense that it didn't.) I assume that would need to be done upstream. I opened 📌 Update "DX: CI" section of CODEOWNERS Active .

Thanks for opening 📌 Update "DX: CI" section of CODEOWNERS Active . That'll be good to resolve. In the meantime, I merged this by temporarily turning off codeowner protection on 0.x. I turned that back on though right after merging this.

Yay, thanks for this thorough improvement, @hooroomoo! 🙏

Automatically closed - issue fixed for 2 weeks with no activity.