CI: improve UI-related CI jobs:`UI eslint` obscures TypeScript Compiler errors, `npm run build` runs too late

Created on 11 July 2024, 4 months ago
Updated 25 July 2024, 4 months ago

Overview

Follow-up for šŸ“Œ Add eslint and type checking to CI jobs Needs work .

@bnjmnm raised 2 DX/velocity concerns while he was working on šŸ“Œ Add component instance edit form to contextual panel RTBC :

  1. šŸ“Œ Add eslint and type checking to CI jobs Needs work introduced the UI eslint CI job. It does not provide clear errors for TS failures, due to us running npm run lint in that CI job and:
        "build": "tsc --noEmit && vite build",
    ā€¦
        "lint:eslint": "eslint . --max-warnings=0",
        "lint": "npm run type-check && npm run lint:eslint",
    
  2. Furthermore, only the Cypress CI job is currently actually building the UI (npm run build). That makes no sense: that CI job should not even be triggered if the build fails ā€” there should be an explicit failure for that instead.

User interface changes

None.

šŸ“Œ Task
Status

Fixed

Component

Page builder

Created by

šŸ‡§šŸ‡ŖBelgium wim leers Ghent šŸ‡§šŸ‡ŖšŸ‡ŖšŸ‡ŗ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024