- Issue created by @anishnirmal
- First commit to issue fork.
- Status changed to Needs review
3 months ago 5:19am 18 September 2024 - ๐ต๐ญPhilippines gslente
Added a merge request to add a README.md to Date Popup.
Kindly review. - ๐ฎ๐ณIndia anishnirmal
@gslente Thank you for adding the README.md file. However, there seems to be a typo in the filename. It is currently named READE.md instead of README.md. Please rename it accordingly.
- ๐ฎ๐ณIndia rushiraval
rushikesh raval โ made their first commit to this issueโs fork.
- ๐ต๐ญPhilippines cleavinjosh
Hi,
Thank you for providing an MR. I applied MR!13, it was applied smoothly and provided a README.md file.
Just a few things to change. According to the README.md template โ ,
- Two lines prior to ##/### headings, in the current, there are one.
- In the table of contents, I think "-" is better than the numbered list
- Ordered lists use "1", in the current, it is incrementing
Please check and advise since I am still new to Drupal.
Thank you. - ๐ต๐ญPhilippines cleavinjosh
Hi @rushikesh raval,
Thank you for updating the MR. I applied MR!13, it was applied smoothly and the changes were reflected.
โ date_popup git:(2.0.2) curl https://git.drupalcode.org/project/date_popup/-/merge_requests/13.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 956 0 956 0 0 2146 0 --:--:-- --:--:-- --:--:-- 2148 patching file README.md โ date_popup git:(2.0.2) โ
Just some clarification, in the Installation section, is that supposed to be an ordered list? My understanding is that those two are steps.
If it is indeed an ordered list, then kindly use the "1" instead of the "-", please see README.md template โ .
Otherwise, this is good to go for the maintainers to review.
Moving the status to Needs work for the meantime.
Thank you. - ๐ฎ๐ณIndia rushiraval
@cleavinjosh Thanks for your review. Please check README.md template โ . There is no firm rules for ordered list / unordered list.
You could try something like this:
# Date Popup## Introduction
The **Date Popup** module enhances all date fields in views filters by adding the native HTML5 date picker widget, making it easier to select and filter dates with an intuitive popup interface.
## Table of Contents
1. [Requirements](#requirements)
2. [Installation](#installation)
3. [Configuration](#configuration)## Requirements
This module does not require any additional modules outside of Drupal core.
## Installation
To install the **Date Popup** module, follow these steps:
1. **Using Composer**
If your Drupal site is managed via Composer, you can install the module by running the following command:
```bash
composer require "drupal/date_popup"