- Issue created by @kim.pepper
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
phpcs is currently passing, but others are not. It might be a good idea to have separate issues for each linter.
- First commit to issue fork.
- 🇺🇸United States jrockowitz Brooklyn, NY
Please lets fix one linting issue per ticket.
Let's address cspell in this ticket.
I think phpstan and phpcbf issue will be much harder to safely address.
-
liam morland →
committed d1b10eac on 6.3.x
Issue #3474074: Sort `use` statements
-
liam morland →
committed d1b10eac on 6.3.x
-
liam morland →
committed debf0270 on 6.3.x
Issue #3474074: Mark nullable parameters with null defaults
-
liam morland →
committed debf0270 on 6.3.x
-
liam morland →
committed d1b10eac on 6.x
Issue #3474074: Sort `use` statements
-
liam morland →
committed d1b10eac on 6.x
-
liam morland →
committed debf0270 on 6.x
Issue #3474074: Mark nullable parameters with null defaults
-
liam morland →
committed debf0270 on 6.x
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
phpcs had been passing and should be passing again with the above changes.
- 🇮🇳India ankitv18
Yes I'm working on cspell pipeline fix only on this issue ~~ will create separate issues for rest of the pipeline fixes.
cc: @liam morland @jrockowitz
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks for the patch.
Why is this needed?
<exclude name="DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter"/>
- 🇮🇳India ankitv18
Even with the proper commenting to include cspell:ignore, the phpcs throws warnings
Please see: https://git.drupalcode.org/issue/webform-3474074/-/jobs/2919966#L43 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Can you not use
phpcs:ignore
to fix that? - 🇮🇳India ankitv18
All done and dusted ~~ Cspell and phpcs both pipelines are clean now.
-
jrockowitz →
committed ecdc79da on 6.3.x authored by
ankitv18 →
Issue #3474074: Fix cspell errors
-
jrockowitz →
committed ecdc79da on 6.3.x authored by
ankitv18 →
-
jrockowitz →
committed ecdc79da on 6.x authored by
ankitv18 →
Issue #3474074: Fix cspell errors
-
jrockowitz →
committed ecdc79da on 6.x authored by
ankitv18 →
Automatically closed - issue fixed for 2 weeks with no activity.
- Merge request !640Issue #3474074: Work-around cspell handling of "whitelist" → (Merged) created by Liam Morland
- Status changed to Fixed
about 1 month ago 10:27pm 4 June 2025