- Issue created by @kim.pepper
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
phpcs is currently passing, but others are not. It might be a good idea to have separate issues for each linter.
- First commit to issue fork.
- ๐บ๐ธUnited States jrockowitz Brooklyn, NY
Please lets fix one linting issue per ticket.
Let's address cspell in this ticket.
I think phpstan and phpcbf issue will be much harder to safely address.
-
liam morland โ
committed d1b10eac on 6.3.x
Issue #3474074: Sort `use` statements
-
liam morland โ
committed d1b10eac on 6.3.x
-
liam morland โ
committed debf0270 on 6.3.x
Issue #3474074: Mark nullable parameters with null defaults
-
liam morland โ
committed debf0270 on 6.3.x
-
liam morland โ
committed d1b10eac on 6.x
Issue #3474074: Sort `use` statements
-
liam morland โ
committed d1b10eac on 6.x
-
liam morland โ
committed debf0270 on 6.x
Issue #3474074: Mark nullable parameters with null defaults
-
liam morland โ
committed debf0270 on 6.x
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
phpcs had been passing and should be passing again with the above changes.
- ๐ฎ๐ณIndia ankitv18
Yes I'm working on cspell pipeline fix only on this issue ~~ will create separate issues for rest of the pipeline fixes.
cc: @liam morland @jrockowitz
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Thanks for the patch.
Why is this needed?
<exclude name="DrupalPractice.Commenting.CommentEmptyLine.SpacingAfter"/>
- ๐ฎ๐ณIndia ankitv18
Even with the proper commenting to include cspell:ignore, the phpcs throws warnings
Please see: https://git.drupalcode.org/issue/webform-3474074/-/jobs/2919966#L43 - ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Can you not use
phpcs:ignore
to fix that? - ๐ฎ๐ณIndia ankitv18
All done and dusted ~~ Cspell and phpcs both pipelines are clean now.
- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
"Uable" should probably be "Unable".
-
jrockowitz โ
committed ecdc79da on 6.3.x authored by
ankitv18 โ
Issue #3474074: Fix cspell errors
-
jrockowitz โ
committed ecdc79da on 6.3.x authored by
ankitv18 โ
-
jrockowitz โ
committed ecdc79da on 6.x authored by
ankitv18 โ
Issue #3474074: Fix cspell errors
-
jrockowitz โ
committed ecdc79da on 6.x authored by
ankitv18 โ
Automatically closed - issue fixed for 2 weeks with no activity.