- Issue created by @mondrake
- Status changed to Needs review
3 months ago 9:37am 13 September 2024 - Status changed to RTBC
3 months ago 7:28pm 16 September 2024 - 🇺🇸United States smustgrave
Test-only feature seemed to skip so ran locally
1) Drupal\Tests\image\FunctionalJavascript\ImageAdminStylesTest::testAjaxEnabledEffectForm Failed asserting that 100 is identical to 400. /var/www/html/web/core/modules/image/tests/src/FunctionalJavascript/ImageAdminStylesTest.php:90
Code review the change makes sense.
- Status changed to Needs work
3 months ago 9:03pm 16 September 2024 - 🇮🇹Italy mondrake 🇮🇹
@smustgrave thanks for your review. Sorry, I took it back to add some more assertions because I cannot understand why the parameter value is 100 at that point - it should be 111.
- Status changed to Needs review
3 months ago 5:15am 17 September 2024 - 🇮🇹Italy mondrake 🇮🇹
Added assertions to confirm the value of the parameter before and after the AJAX calls.
- Status changed to RTBC
3 months ago 2:11pm 17 September 2024 - 🇺🇸United States smustgrave
Ran test locally again
Behat\Mink\Exception\ExpectationException: The field "data[test_parameter]" value is "100", but "111" expected.
Which appears to be the new assertion added.
- 🇮🇹Italy mondrake 🇮🇹
Yep, #5 the failing value was 100 and not 111 exactly for the same bug, which gets fixed here. Just the existing test was not catching it.
- 🇬🇧United Kingdom catch
Tricky issue but the explanation and code change makes sense. One comment on the test coverage.
- 🇮🇹Italy mondrake 🇮🇹
Switched to use
assertExpectedAjaxRequest()
as suggested. - 🇫🇷France nod_ Lille
Committed and pushed 4bfa1e9987e to 11.x and 50692daf255 to 11.0.x and c2bdd141b48 to 10.4.x and a0b547ee0f9 to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.