Simplify WYSIWIG stylesheet approach

Open on Drupal.org →

Created on 12 September 2024, 5 months ago

Problem/Motivation

Currently we rely on SCSS to wrap ckeditor 5 stylesheets in .ck-content. This is cumbersome as it requires wrapping base and element styles in a mixin, then immediately calling that mixin.

There are also a couple existing bugs related to this approach:

The wysiwyg stylesheet outputs unprefixed styles along with the prefixed styles. Which will cause rendering issues in admin themes.
:root selectors get prefixed with .ck-content which results in an invalid selector.

Solution

Install and configure postcss-prefixwrap

🐛 Bug report

Status

Postponed

Version

5.0

Component

Code

Created by

🇺🇸United States pixelwhip

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!147Simplify WYSIWIG stylesheet approach
Merged
🇺🇸United States pixelwhip
updated 5 months ago

Comments & Activities

Issue created by @pixelwhip
Merge request !147Issue #3473791: Initial configuration of the postcss-prefixwrap plugin. → (Merged) created by pixelwhip
Comment 5 months ago →
🇺🇸United States pixelwhip
Status changed to Postponed 5 months ago10:37am 12 September 2024
Comment 5 months ago →
🇺🇸United States pixelwhip
I've added the initial configuration for the plugin and updated a couple files as a proof of concept.

Marking this postponed until 3469567 📌 Component Folder Structure Needs work is resolved to avoid the inevitable merge conflicts.
Comment 5 months ago →
🇺🇸United States jldust
We have now pulled in the component folder update, this needs to be rebased off the main 5.x branch and then it should be ready for review.
Comment 5 months ago →
System Message
pixelwhip → closed merge request !147
Comment 5 months ago →
System Message
pixelwhip → reopened merge request !147
Comment 5 months ago →
🇺🇸United States pixelwhip
This is ready for review. It has been rebased onto the latest 5.x branch.
Comment 5 months ago →
🇺🇸United States philip_stier Denver, Colorado
This looks great! Thanks for the much needed changed John!
Pipeline finished with Skipped
5 months ago
#300951
Comment 5 months ago →
System Message

jldust → committed f195dfc9 on 5.x authored by pixelwhip →
Issue #3473791 by pixelwhip, jldust, philip_stier: Simplify WYSIWIG...
Comment 5 months ago →
🇺🇸United States jldust
Thanks all! This has been merged and will be included in the next tagged release.
Comment 5 months ago →
🇺🇸United States jldust

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024