🇺🇸United States @philip_stier

I attended this meeting :)

I attended this meeting :)

I completed the survey :)

I attended this meeting.

jldust → credited philip_stier → .

I attended this meeting

philip_stier → created an issue.

I attended this meeting :)

philip_stier → created an issue.

philip_stier → changed the visibility of the branch 3480006-updated-accordion-component to hidden.

philip_stier → created an issue.

I had forgotten probably the more important form updates >_< Should be ready for merging now :)

This looks great! Thanks for the much needed changed John!

philip_stier → created an issue.

I've created an MR with Drupal Token support

philip_stier → created an issue.

I attended this meeting :)

I attended this meeting

I attended this meeting :)

I was at this meeting :)

philip_stier → created an issue.

@jldust / @pixelwhip - Also, do you think any of the 06-utilities can just go under 00-base/global?

@jldust / @pixelwhip - Thinking in idealogical order, do you think the pages directory and the regions directory should be switched? So:

/04-regions
/05-pages

@jldust / @pixelwhip - Is there any downsides to having all of the partials nested inside the 00-base directory? If we're trying to consolidate, why not everything, right? This would effectively negate the need for the 'libraries' directory.

There are several – more philosophical – questions that I have mostly for an accessibility expert, but otherwise, this change looks great! Ready to merge :)

Changes look good! Ready to merge.

I attended this meeting.

@liam morland - I have not tested on Webform 6.3.x yet, no. The site that I am working on is on Drupal 10.2 still, which is incompatible with Webform 6.3.x.

philip_stier → created an issue.

I am also running into this issue, however, specifically when a webform is embedded into a node. I'm using Layout Paragraphs with a Paragraph entity that references Webforms. Once a Webform is embedded onto a page this way, the local tasks for that node page changes and adds incorrect Webform reference links.

For Example: /node/100677/webform/results/submissions

I am volunteering both days

Created a MR for this.

I am also running into this issue and have confirmed that the patch works :)

philip_stier → created an issue.

@jldust / @pixelwhip - I've updated the Typography partial accordingly :)

philip_stier → created an issue.

@jldust / @pixelwhip - I've updated the Spacing partial accordingly :)

philip_stier → created an issue.

@jldust - This looks and works great! Just tested successfully myself :)

Thank you for the direction @leslieg!

@jldust - I've created a merge request that replaces the current logo.png file (corrupted) with a new one featuring the new branding. I even re-introduced the blue that you were missing so much >_<

Here :)

philip_stier → made their first commit to this issue’s fork.

@jldust - Logos refreshed and I've also added a favicon style logo for the page :)

@ravi kant – TWIG isn't really meant to contain a lot of complex logic. All of that really should go into preprocess/extra fields/field formatters. That is probably the primary reason why switch statements are not a thing in core TWIG.

@jldust - Looks good to me!

philip_stier → changed the visibility of the branch 3374467- to hidden.

philip_stier → changed the visibility of the branch 3374467-component-tabs to hidden.

@pixelwhip and @jldust - I've updated the naming of tabs components into "tabs-content" and "menu-tabs". Ready for review again :)

I'm here :)

philip_stier → created an issue.

Looks good to me @jldust!

Looks good to me @jldust!

Here!

philip_stier → created an issue.

I was also getting this exact same error with Entity Browser. #6 worked for me. Drupal 10.1.7

philip_stier → created an issue.

@jldust - I think this new Tabs component is ready for review!

I've added the access checks in the fork and have confirmed that these updates fix the issue – cron job is now successful again.

philip_stier → created an issue.

I’m sorry @jldust, but I don’t think “Teaser” and “Card” should be the same thing. I also don’t think that these should be 3 separate components. Teaser should be one component with all of the different variations inside of it. Same with Cards.

philip_stier → created an issue.

MatthewS → credited philip_stier → .

MatthewS → credited philip_stier → .

philip_stier → created an issue.

philip_stier → created an issue.

@jldust - As mentioned, I can help transpose this into Vanilla JavaScript, but looks good for now :)

@jldust / @pixelwhip - I've gone the route of using mixins for necessary theming that is needed for CKEditor. I've added comments everywhere that I am doing this to be clear on what is going on.

@pixelwhip explained to me that CKEditor5 is now not loaded as an iFrame, versus how CKEditor4 is being loaded, so if we don't load our styles inside of the CKEditor wrapper class, they will be applied to the admin theme as a whole.

@jldust / @pixelwhip - I've updated a new MR off of the 5.x branch. Thank you Ferris for doing all of the upfront work!

philip_stier → made their first commit to this issue’s fork.

@jldust / @pixelwhip - I opened a new branch off of 5.x and updated the WYSIWYG file to use `@use` statements. I didn't add the class wrapper, but do we really need it? As long as the styles that are being defined for the front end are also being loaded into CKEditor, we shouldn't need the wrapper?

philip_stier → made their first commit to this issue’s fork.

philip_stier → created an issue.

@jldust - This looks good for merging to me!

@jldust - I've updated the mixin for fonts per our conversation :)

@jldust - I've updated my merge request to remove the extraneous CSS files and the extra components directory :)

@jldust - These changes should be ready for merging :)

philip_stier → created an issue.

@jldust - I merged in your updates from the Typography Variables update and have made adjustments accordingly. I kept most of what you put together and tweaked a little here and there, which we can talk about :)

@jldust – Looks good to me! Ready to merge.

philip_stier → created an issue.

@jldust - I'm not exactly certain how, or if we can delete a fork and start over, but the fork that I created was off of the 4.x branch. So I'm thinking we close this issue and start a new one fresh :)