Great catch, this has been merged in and will be included in the next tagged release.
Thanks for making those updates, this is getting pretty close.
We have a few outstanding thoughts/questions:
- With the update to layouts.scss should the root selectors be moved into 00-base and then move the other pieces into their own sections within the 03-layouts folder. (IE flex, container)
- For the page directory should we add a base SCSS file for each of those folders and then load it in the libraries file? (Example: basic/basic.scss)
Thanks for creating some documentation!
I've created a MR with the patch applied, I'm new to test writing so I'm not sure where to start for this specific issue. If there is a specific guide page I would be happy to look at it!
Confirming that patch #2 works cleanly on Drupal 10.3.2 with Paragraphs v1.18. Does this change need tests to be updated?
With the release of the 5.2.1-alpha2 branche we have managed to complete some larger steps towards a stable 5.x branch. Below is an updated list of remaining tasks, those that have been completed have been crossed off. Note that we have marked a11y components completed, the initial release has preliminary review and we are going to have an in depth review after stable as well.
Remaining tasks
- Add 5 new component features: , , , Updated Menu, and
- Clean up codebase & formating
Notes from our meeting:
- Move components nested in elements to the 02-components folder
- Move SCSS files within the respected nested 00 folders brought up in discussion
Great meeting thanks all!
This has been merged and will be included in the next tagged release.
This has been merged and will be included in the next tagged release.
Going to rework the parent structure so this is a duplicate
I've updated to Gulp 5 and quite a few dependant packages, this is ready for review. There were a few minor updates required due to changes related to SASS & CSS that can be viewed here: https://sass-lang.com/documentation/breaking-changes/mixed-decls/
In addition there is a notification for a deprecation related to fs.stats from vinyl-named that the team is aware of: https://github.com/gulpjs/vinyl-fs/issues/354
I tested this and it created the config files as I would expect solving the issue I was running into, thanks!
Looks good, this has been merged in and will be included in the next tagged release.
Thanks for the review and feedback, this has been merged and will be included in the next tagged release.
Thanks for the review, this has been merged in and will be included in the next tagged release.
This has been merged into to update required core version to 10.3+ and remove SDC requirement as it is now enabled by core.
Thanks for testing this, I agree about merging this in and creating another ticket to resolve the Cypress testing issues.
jldust → changed the visibility of the branch 3467253-remove-sdc-requirement to active.
jldust → changed the visibility of the branch 3467253-remove-sdc-requirement to hidden.
Hey all, I would love to help support this track as well! I presented on technical documentation during DrupalCon 2022 and have years of experience with technical writing along with teaching in higher education at the US Collegiate level. Currently I support Drupal core with documentation on SDC along with a custom starterkit theme called Prototype. I also have experience reviewing existing documentation and testing user workflows and tutorials.
I agree that this needs to be more extensive, I'm seeing these broken references with selection options as well.
There is some documentation in the root of the project README and you can review our documentation page for the 5.x branch here → .
Thank you for highlighting this, I'll look into a theme demo and updating or documentation for overall clarity.
This has been merged in and will be included in the next tagged release.
This has been reviewed and approved to merge.
Hey this is ready for review, I created a MR.
Prototype does not support hover based interactions. Looking at your navigation the top level item needs to be a button and not a link for it to be able to open.
This has been merged in and will be included in the next tagged release.
This updated component structure is ready for review.
This has been merged in and will be included in the next tagged release. We have identified a few minor issues related to the mobile toggle button that will be opened as independent issues.
This has been merged in and will be included in the next tagged release.
This has been merged in and will be included in the next tagged release.
Thanks for all your work on this, we have merged the new logo in and it will be included in the next tagged release.
This has been merged in and will be included in the next tagged release.
jldust → changed the visibility of the branch 3398391-updated-menu-component to hidden.
jldust → changed the visibility of the branch 3398391-convert-menu-component to active.
jldust → changed the visibility of the branch 3398391-convert-menu-component to hidden.
At this time we have decided to not include an alert component within Prototype, however this may change in the future.
Great thank you, this has been merged in and will be included in the next tagged release.
This looks great, thank you! I've merged this in to be included in the next tagged release.
I'm also running into the issue called out in #7 when adding it to the composer file. That appears to also have an open issue here: https://www.drupal.org/project/okta_api/issues/3418721 📌 Oktasdk-php patch is no longer needed Active