Implements iconSprite parameter

Created on 10 October 2022, over 2 years ago
Updated 19 September 2024, 7 months ago

Problem/Motivation

Since MediaElement 5.0.0 was added the parameter iconSprite that indicates the location of the svg icon controls and is needed to be set on the library instance in order to show correctly the player.

More info: https://github.com/mediaelement/mediaelement/blob/6b21f69a048f42ff2447b4...

Proposed resolution

Creates a new settings under player_settings to stores the path of the svg, by default sets '/libraries/mediaelement/build/mejs-controls.svg'.

Remaining tasks

This parameter of MediaElement could be problematic using CDN, in this moment i don't know how to handle, temporary local library is required to set the local path of the svg.

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇷Costa Rica maxmendez

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India junaidpv Kannur, Kerala

    I don't think that needs to be a configurable one. It is a known path within the library and usually no need to change.
    Here is a version that works with both local and CDN. Without making that configurable thus a simpler patch.

Production build 0.71.5 2024