- Issue created by @jldust
- πΊπΈUnited States philip_stier Denver, Colorado
@jldust / @pixelwhip - Is there any downsides to having all of the partials nested inside the 00-base directory? If we're trying to consolidate, why not everything, right? This would effectively negate the need for the 'libraries' directory.
- πΊπΈUnited States philip_stier Denver, Colorado
@jldust / @pixelwhip - Thinking in idealogical order, do you think the pages directory and the regions directory should be switched? So:
/04-regions
/05-pages - πΊπΈUnited States philip_stier Denver, Colorado
@jldust / @pixelwhip - Also, do you think any of the 06-utilities can just go under 00-base/global?
- Merge request !1433469567-component-folder-structure/Philip: Directory adjustments β (Merged) created by philip_stier
- Status changed to Needs review
6 months ago 7:41pm 29 August 2024 - Status changed to Needs work
6 months ago 10:37pm 4 September 2024 - πΊπΈUnited States jldust
Notes from our meeting:
- Move components nested in elements to the 02-components folder
- Move SCSS files within the respected nested 00 folders brought up in discussion - First commit to issue fork.
- πΊπΈUnited States pixelwhip
Rebased the merge request onto the latest 5.x.
- πΊπΈUnited States pixelwhip
Closed and reopened the merge request to get tugboat to rebuild.
- πΊπΈUnited States pixelwhip
@jldust & @philip_stier I've made some updates to this and it's ready for review again.
- Moved any element selectors to the 01-elements
- Moved layouts in 03-layouts
- Moved the regions to 04-regions
- Adjusted the cypress tests to work with the new structure.
- Updated the libraries.yml file to match
- Status changed to Needs review
5 months ago 8:08pm 12 September 2024 - Assigned to pixelwhip
- πΊπΈUnited States jldust
Thanks for making those updates, this is getting pretty close.
We have a few outstanding thoughts/questions:
- With the update to layouts.scss should the root selectors be moved into 00-base and then move the other pieces into their own sections within the 03-layouts folder. (IE flex, container)
- For the page directory should we add a base SCSS file for each of those folders and then load it in the libraries file? (Example: basic/basic.scss)
- πΊπΈUnited States pixelwhip
Good catch on the :root styles. I did wonder about those. I think the only time :root styles outside of 00-base are appropriate is if they are component specific. In which case they should be namespaced as
--prototype-[component-name]-[property]
. I thought that was a little ambiguous with the grid and width custom props. I had to ask if these properties could be applicable outside of the context of those utility classes and figured they could be, but am not 100% convinced. I moved them for now for consistency sake. I also updated the grid property to leverage the spacing props.I added a blank stylesheet for the page template. I removed the landing page folder as I don't think we should have more than one example folder without a corresponding template. Otherwise it's more stuff that may need to be deleted. It probably is a good idea to have a starter landing page template with corresponding styles but that could be another issue.
-
jldust β
committed 7f67b1c7 on 5.x authored by
philip_stier β
Issue #3469567 by philip_stier, pixelwhip, jldust: Component Folder...
-
jldust β
committed 7f67b1c7 on 5.x authored by
philip_stier β
- πΊπΈUnited States jldust
This looks great, thanks for all the work on getting the folder structure updated. This will be included in the next tagged release.