Clarify “Database support for JSON” success requirement message for Drupal 11

The requirement check and message is in system.install.

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.

Now this is a new major, it makes to remove it altogether?

Something more concrete, along the lines of

“Drupal requires databases support JSON”

Agreed. Issue summary updated.

/core/modules/system/tests/src/Functional/System/StatusTest.php fails.

An unrelated test fails. Leaving the status as Needs review for now.

Failure was random, all green after re-running test.

Change seems small enough and matches the summary I don't mind marking now.

What about removing the REQUIREMENT_OK version of this? To me it's just wasted space on the status report, we should definitely error if this check fails but I don't feel like "Drupal requires databases that support JSON" actually tells the system administrator anything useful if their database already supports it.

Does removing something from the status report page require product manager review?

Who is the database product manager?

On the MySQL side, Drupal 11 requires “MySQL/Percona 8.0”.

https://www.drupal.org/docs/getting-started/system-requirements/database... →

If MySQL 8.x supports JSON by default, I tend to agree with longwage.

Looking again at at the status page, we have:

Database support for JSON
Available
Is required in Drupal 10.0.

To be consistent with other requirements status we can simplify to:

Database support for JSON
Available

However, since this JSON support is “Required” for Drupal 10 and 11, we might prefer:

Database support for JSON
Enabled

As for the correct solution to implement (change of text) or the removal of the confirmation status, I would defer to the database product manager.

It looks like that Drupal can be installed without JSON supportL

if (!Database::getConnection()->hasJson()) {
  $requirements['database_support_json']['value'] = t('Not available');
  $requirements['database_support_json']['severity'] = REQUIREMENT_ERROR;
}

So the status report will display either:

Database support for JSON
Available
Is required in Drupal 10.0.

Note that I did not try to install Drupal on top of a database without JSON support. But by ready the code, installing Drupal without JSON support is possible, unless the installer halts early on, displaying a missing requirement error message.

or

Database support for JSON
Not available
Is required in Drupal 10.0.

Based on that information, we should simplify to:

Database support for JSON
Available

or

Database support for JSON
Not available

@daffie is the database subsystem maintainer, tagging for review.

I did as the subsystem maintainer a review and therefore I have removed the tag.
Changing the status to needs work for the nitpick on the MR.

Thanks for the quick resposte, daffie.

Let's plan to implement this:

Database support for JSON
Available
Drupal requires databases that support JSON storage.

or

Database support for JSON
Not available
Drupal requires databases that support JSON storage.

That last one, hopefully, mostly not visible ot users.

Text changed to match the subsystem maintainer review.

The new message looks good to me.
It should be better for the site owner and it allow us to add checks on JSON functionality from the database at a later point in time.
For me it is RTBC.